Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] questions in Mertic:issue duration resolution #1026

Closed
longyanz opened this issue Nov 4, 2022 · 8 comments · Fixed by #1063
Closed

[bug] questions in Mertic:issue duration resolution #1026

longyanz opened this issue Nov 4, 2022 · 8 comments · Fixed by #1063
Assignees
Labels
kind/bug Category issues or prs related to bug. kind/question Category issues related to questions or problems waiting for repliers need other's feedback

Comments

@longyanz
Copy link
Contributor

longyanz commented Nov 4, 2022

Hi @frank-zsy ,when I read duration resolution metric in handbook.ipynb, I found this metric return a value about 4700 days. I think this maybe wrong
image

So I find some issues in our clickhouse and there issue open event missed. I think this caused the wrong result.
image
(microsoft/vscode#122346)
and in this clause, open_at field return 1970-1-1 .
image

@open-digger-bot open-digger-bot bot added kind/bug Category issues or prs related to bug. kind/question Category issues related to questions or problems labels Nov 4, 2022
@github-actions github-actions bot added the waiting for repliers need other's feedback label Nov 4, 2022
@frank-zsy
Copy link
Contributor

It's because the opened action was lost in the event log, so opened_at return as a null value which is 1970-1-1 when the type is DateTime. We should consider this since there may some lost data in the event log.

When the opened_at can not be found, we may use the first comment event instead, does this make sense to you?

@github-actions github-actions bot added waiting for author need issue author's feedback and removed waiting for repliers need other's feedback labels Nov 4, 2022
@longyanz
Copy link
Contributor Author

longyanz commented Nov 4, 2022

Thanks!

@github-actions github-actions bot added waiting for repliers need other's feedback and removed waiting for author need issue author's feedback labels Nov 4, 2022
@frank-zsy
Copy link
Contributor

It is really tricky if some events lost in the log, I will give a detail look into the problem later.

/self-assign

@github-actions github-actions bot added waiting for author need issue author's feedback and removed waiting for repliers need other's feedback labels Nov 4, 2022
@xgdyp
Copy link
Contributor

xgdyp commented Nov 8, 2022

Hi @frank-zsy , why we don't use issue_created_at and issue_closed_at field to avoid this problem?

@frank-zsy
Copy link
Contributor

Hi @frank-zsy , why we don't use issue_created_at and issue_closed_at field to avoid this problem?

Yes! Great point, I think I just forgot the uncommonly used columns which is quite useful in this situation.

@longyanz
Copy link
Contributor Author

longyanz commented Nov 8, 2022

Hi, we use argMax(issue_created_at,created_at) AS opened_at instead of maxIf(created_at, action = 'opened') AS closed_at
5fbdb9613a7adfb4d093e71329141ac

It seems the result is correct.

52a95ac1010dfaac72e02f9297115a3

@github-actions github-actions bot added waiting for repliers need other's feedback and removed waiting for author need issue author's feedback labels Nov 8, 2022
@frank-zsy
Copy link
Contributor

@longyanz Great, can you fix this?

@github-actions github-actions bot added waiting for author need issue author's feedback and removed waiting for repliers need other's feedback labels Nov 8, 2022
@longyanz
Copy link
Contributor Author

longyanz commented Nov 8, 2022

I will fix it after @xgdyp finish separating python kernel and nodejs kernel #1008 ~

@github-actions github-actions bot added waiting for repliers need other's feedback and removed waiting for author need issue author's feedback labels Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Category issues or prs related to bug. kind/question Category issues related to questions or problems waiting for repliers need other's feedback
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants