Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add docs for Python kernel #968

Closed
frank-zsy opened this issue Sep 13, 2022 · 7 comments
Closed

[Docs] Add docs for Python kernel #968

frank-zsy opened this issue Sep 13, 2022 · 7 comments
Labels
area/document Category issues or prs related to document. waiting for author need issue author's feedback

Comments

@frank-zsy
Copy link
Contributor

We need to add docs for Python kernel and also push Python kernel docker image for developers to use.

@open-digger-bot open-digger-bot bot added the area/document Category issues or prs related to document. label Sep 13, 2022
@open-digger-bot
Copy link
Contributor

This issue has not been replied for 24 hours, please pay attention to this issue: @gymgym1212 @xiaoya-yaya

@yoyo-wu98
Copy link
Contributor

During writing the doc of Sample Data Usage for Python Kernel #998 , I find the doc a bit difficult to read through.
I think the structure of the open-digger is a bit complex and unfriendly to both node.js and python developers.
Is there any plan to tell the 2 versions(node.js and python) apart? Or some better idea? Or is this the current structure the best choice?

@frank-zsy
Copy link
Contributor Author

Yes, actually I think a better idea is to separate the python and node.js kernel file into different folders like src/node/ and src/python, so developers can understand better and focused on a certain kernel.

@xgdyp
Copy link
Contributor

xgdyp commented Oct 14, 2022

Hello @frank-zsy , I think we can store our python_kernel image into our remote DockerHub so we don't have to build image again. What do you think?

@xgdyp
Copy link
Contributor

xgdyp commented Oct 14, 2022

Would you like to test the new docs on #998?@Zi1l

@frank-zsy
Copy link
Contributor Author

frank-zsy commented Oct 14, 2022

Hello @frank-zsy , I think we can store our python_kernel image into our remote DockerHub so we don't have to build image again. What do you think?

Yes, of course.

@l1tok
Copy link
Contributor

l1tok commented Oct 22, 2022

Would you like to test the new docs on #998?@Zi1l

Based on the new docs with python_kernel, open-digger can run successfully. Besides, I am sorry that I didn't see the message in time because of the chage of my ID.

@github-actions github-actions bot added the waiting for author need issue author's feedback label Oct 22, 2022
@xgdyp xgdyp closed this as completed Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/document Category issues or prs related to document. waiting for author need issue author's feedback
Projects
None yet
Development

No branches or pull requests

4 participants