Code

Isolate the Chrome crash#26

Code

Closed

adamziel wants to merge 198 commits intotrunkWordPress/wordpress-playground:trunkfrom debugging-chrome-crashWordPress/wordpress-playground:debugging-chrome-crashCopy head branch name to clipboard

+1,401,293-914

Commits

Commits on Oct 3, 2022

• Reduced state and still crashing: No service worker, no messaging, just WPBrowser in web worker

  adamziel

  committed
  5d20650

• Reduced state, still crashing: no PHP code execution after the initial load

  adamziel

  committed
  1ebcd45

• Further reduced state: No imports. Still crashing!

  adamziel

  committed
  f4dbc74

• Put the webworker code in setTimeout call – still crashing

  adamziel

  committed
  665f1ae

• Reduced state, no crashes, commented out new PHPWrapper() and php.init()

  adamziel

  committed
  cc20d17

• No crasehs: Restored new PHPWrapper( );

  adamziel

  committed
  6c8c806

• Crashes: Restored php.init() -> it's crashing again!

  adamziel

  committed
  ba91296

• Crashes: No default arguments to PhpBinary

  adamziel

  committed
  848938a

• Crashes: new PHP with ccall pib_init

  adamziel

  committed
  df0b985

• Crashes: new PHP without ccall

  adamziel

  committed
  10f025e

• Crashes: without document = {}

  adamziel

  committed
  508e7db

• Formatted webworker-php.js

  adamziel

  committed
  523907c

• Run prettier on webworker-php.js

  adamziel

  committed
  0f067d3

• Keeps crashing: Added early "return;" in run()!

  adamziel

  committed
  fbc5928

• Keeps crashing: ccall removed

  adamziel

  committed
  b6bb7dc

• Still crashing: Stripped more emscripten JS code

  adamziel

  committed
  fde20c8

• Keeps crashing: Removed receiveInstantiatedSource – WASM isn't being instantiated now! It must be about streaming

  adamziel

  committed
  93569dc

• Keeps crashing: Stripped asm2wasm to an empty function in instantiateStreaming info

  adamziel

  committed
  7ed1ffd

• Keeps crashing: Replaced all functions in info.env with empty functions

  adamziel

  committed
  cddbdc9

• Crash: Remove the system functions provided to wasm as they're distracting and do not cause the crash

  adamziel

  committed
  0d333f2

• Crashes: Remove stacktrace handling code as it distracts and doesn't cause the crash

  adamziel

  committed
  bf68a6c

• Crashes: Remove FS handling code as it's distracting and doesn't cause the crash

  adamziel

  committed
  2f5790f

• Crashes: Remove usleep and ATINIT

  adamziel

  committed
  91208c6

• Crashes: Remove UTF-8 handling code

  adamziel

  committed
  34196e1

• Crashes: Remove memory management code

  adamziel

  committed
  aa03a39

• Crashes: Remove unnecessary initialization code

  adamziel

  committed
  71aa5db

• Crashes: Remove dependency management

  adamziel

  committed
  1568e2c

• Crashes: Remove non-essential initialization code

  adamziel

  committed
  6da983c

• Crashes: Simplify the formatting

  adamziel

  committed
  7db78ad

• Crashes: Remove more non-essential initialization code

  adamziel

  committed
  030a9a2

• Crashes: Remove more non-essential initialization code

  adamziel

  committed
  5be3673

• Crashes: Merge both webworker files into a single one to avoid calling importScripts

  adamziel

  committed
  d41d036

• Crashes: Double the initial memory size

  adamziel

  committed
  963dc78

• Crashes: Move the WASM initialization code to the global scope

  adamziel

  committed
  ce77f2d

• Crashes: Remove more non-essential code

  adamziel

  committed
  9bad613

• Crashes: Remove , { credentials: 'same-origin' }

  adamziel

  committed
  c4be5d7

• Reduce INITIAL_INITIAL_MEMORY to its original size

  adamziel

  committed
  b3d747c

• No crash – build process that yields a reliable wasm binary

  adamziel

  committed
  4edd1ec

• No crash: Uses php_embed_shutdown but no php_embed_init

  adamziel

  committed
  b34e8ed

• Crash: sapi_startup

  adamziel

  committed
  37ae5d5

• Crash: sapi_module = *(&php_embed_module);

  adamziel

  committed
  ec8607c

• Crash: private_sapi_module

  adamziel

  committed
  4231c25

• No crash: php_embed_startup without php_module_startup

  adamziel

  committed
  792c15a

• Crash: php_module_startup uncommented

  adamziel

  committed
  ff3800c

• Crash – zend_startup

  adamziel

  committed
  819aa3a

• Crash: gc_globals_ctor, zend_startup

  adamziel

  committed
  8d533a5

• Crash; gc_globals_ctor

  adamziel

  committed
  b852a50

• Crash: no gc_globals_ctor

  adamziel

  committed
  b150cbe

• Crash: no memset and php_startup_ticks

  adamziel

  committed
  050a119

• Crash: no sapi_activate

  adamziel

  committed
  1d02d84

• Crash: no sapi_initialize_empty_request

  adamziel

  committed
  c0532c8

• Crash: empty php_embed_startup

  adamziel

  committed
  2559fc6

• Crash: half of php_embed_module2 empty

  adamziel

  committed
  7b18686

• Crash: empty most of php_embed_module2

  adamziel

  committed
  cec08ec

• Crash: empty php_embed_module2

  adamziel

  committed
  53d6b2d

• Crash: empty half of php_embed_init

  adamziel

  committed
  1393b53

• Crash: empty php_embed_init

  adamziel

  committed
  2b5b2a5

• No crash: empty php_embed_shutdown and a few other functions

  adamziel

  committed
  8c26c6c

• No crash: empty just php_embed_shutdown

  adamziel

  committed
  7bc4504

• Crash: Just php_request_shutdown

  adamziel

  committed
  f1028ca

• Crash: Only php_request_shutdown in pib_init

  adamziel

  committed
  13b3b9a

• Crash: Only php_request_shutdown in pib_init

  adamziel

  committed
  e2fc234

• Crash: Inlined php_request_shutdown2

  adamziel

  committed
  8f62c12

• Crash: Half of php_request_shutdown2 empty

  adamziel

  committed
  f3095d6

• Crash: 3/4 of php_request_shutdown2 empty

  adamziel

  committed
  c12af31

• No crash: 1/8 of php_request_shutdown2

  adamziel

  committed
  50f5868

• Crash: Another 1/8 of the php_request_shutdown2

  adamziel

  committed
  2cdec88

• Crash: Just php_call_shutdown_functions

  adamziel

  committed
  aeacfeb

Commits on Oct 4, 2022

• Crash: brought php_call_shutdown_functions to pib_eval.c

  adamziel

  committed
  6e784b6

• Crash: Simplofy pib_eval.c

  adamziel

  committed
  75abc9f

• No crash: emopty user_shutdown_function_call2

  adamziel

  committed
  f6c195d

• No crash: Half of user_shutdown_function_call2

  adamziel

  committed
  78fa68d

• Crash: zend_call_function

  adamziel

  committed
  cfe7614

• Crash: Minimal zend_call_function repro

  adamziel

  committed
  4c8bc14

• No crash: Half of zend_call_function

  adamziel

  committed
  98a5a19

• Crash: zend_vm_stack_free_args zend_vm_stack_free_call_frame

  adamziel

  committed
  489063a

• No crash: without zend_vm_stack_free_args

  adamziel

  committed
  b30df6e

• Crash: cleanup

  adamziel

  committed
  eb5e461

• Crash: Cleanup

  adamziel

  committed
  1beffaf

• Crash: No loop

  adamziel

  committed
  542a5d6

• Crash: One if less

  adamziel

  committed
  c0bb287

• No crash: Removed big if

  adamziel

  committed
  224e243

• Crash: Stripped down more supporting code in zend_call_function

  adamziel

  committed
  ed05fcf

• No crash: Removed another chunk of supporting code

  adamziel

  committed
  ab12acf

• Crash: Removed a different code path

  adamziel

  committed
  25ca966

• Crash: Just zend_handle_undef_args

  adamziel

  committed
  9beb14c

• Crash: Minimal crash reproduction with a copy of Zend/zend_execute.c

  adamziel

  committed
  786df0e

• Crash: Half of zend_handle_undef_args2

  adamziel

  committed
  32b2d1f

• Crash: zend_handle_undef_args2 further stripped dopwn

  adamziel

  committed
  eb9efb5

• No crash: Removed start_fake_frame and zval_update_constant_ex from zend_handle_undef_args2

  adamziel

  committed
  d9a6354

• Crash: Just zval_update_constant_ex

  adamziel

  committed
  6ac8c29

• Crash: zval_update_constant_ex ported to pib_eval.c

  adamziel

  committed
  f144ac9

• Crash: One of

  Show description for 40d7f4c
  adamziel

  committed
  40d7f4c

• Crash: just zend_ast_evaluate

  adamziel

  committed
  669d987

• Crash: One of (see the commit message below)

  Show description for df66d63
  adamziel

  committed
  df66d63

• Crash: One of zend_string_init(name, 10, 0); zend_string_equals_literal_ci(class_name, "self"); zend_fetch_class(class_name, 0); zend_get_called_scope(EG(current_execute_data));

  adamziel

  committed
  7c50534

• Crash: zend_fetch_class

  adamziel

  committed
  2c052aa

• Crash: just zend_lookup_class_ex

  adamziel

  committed
  7f48ad9

• Crash: zend_exception_save

  adamziel

  committed
  8d902e3

• Crash: Copied zend_exception.c

  adamziel

  committed
  56780d6

• Crash: Half of zend_exception_set_previous

  adamziel

  committed
  acf28b7

• Crash: OBJ_RELEASE(add_previous);

  adamziel

  committed
  0f15e9f

• Crash: zend_objects_store_del

  adamziel

  committed
  bf4f0fa

• Crash: Minimal repro with zend_objects_store_del

  adamziel

  committed
  9e88a99

• Crash: Half of zend_objects_store_del

  adamziel

  committed
  fafcad2

• Crash: Almost the minimal repro with GC_SET_REFCOUND

  adamziel

  committed
  40fec96

• Crash: Minimal repro with object->handlers->dtor_obj != zend_objects_destroy_object;

  adamziel

  committed
  8b66678

• Crash: zend_call_known_instance_method_with_0_params

  adamziel

  committed
  e285ebd

• Back to zend_call_function but not pursuing zend_handle_undef_args this

  Show description for 0d5a0ed
  adamziel

  committed
  0d5a0ed

• Crash: zend_call_function again, second half of the function removed

  adamziel

  committed
  06ee620

• Crash: Probably zend_is_callable_ex

  adamziel

  committed
  6e42626

• Crash: Zeroing in on a self-contained example without PHP in the mix

  adamziel

  committed
  3acb026

• Crash: Reduced to free()

  adamziel

  committed
  9643fdb

• Crash: Got to zend_array

  adamziel

  committed
  2aa4d7a

• Narrowed down to zend_refcounted_h

  adamziel

  committed
  bbf046e

• Crash: Progress towards an isolated use case

  adamziel

  committed
  723d374

• No crash: Defused code excerpt. Trying to arm it again

  adamziel

  committed
  42f9f3b

• No crash: Trying to arm the defused code

  adamziel

  committed
  c201dfc

• Crash: Start debugging the WASM file directly

  adamziel

  committed
  70ca44c

• Crash: removed _zend_get_constant_ex

  adamziel

  committed
  f273500

• Remove call $_zend_handle_encoding_declaration

  adamziel

  committed
  b39c959

• Removed _zend_compile_const_expr_class_name _zend_compile_const_expr_class_const _zend_compile_const_expr_const _zend_compile_const_expr

  adamziel

  committed
  be12f25

• Remove _zend_throw_or_error

  adamziel

  committed
  0b8aac0

• Remove a few more functions

  adamziel

  committed
  0ad43b8

• Remove more functions

  adamziel

  committed
  a1be88b

• Remove more functions

  adamziel

  committed
  dc172f4

• Delete more functios

  adamziel

  committed
  4ae2118

• Crash: Remove mallocs

  adamziel

  committed
  59c3ae9

• Crash: Use smaller initial memory

  adamziel

  committed
  4a09ec8

Commits on Oct 5, 2022

• Crash: Add python utils to reduce the wasm build bit by bit

  adamziel

  committed
  77d4291

• Crash: Iteration 2 of remove_unused_functions

  adamziel

  committed
  b646a78

• Crash: Iteration #3 of remove_unused_functions

  adamziel

  committed
  47b6db1

• Crash: Iteration #4 of remove_unused_functions

  adamziel

  committed
  957f5b1

• Crash: Iteration #5 of remove_unused_functions

  adamziel

  committed
  925206f

• Crash: removed (func $abortStackOverflow (type 0)

  adamziel

  committed
  53bc9d9

• Crash: remove $_rc_dtor_func2

  adamziel

  committed
  b3a3363

• Crash: remove $_zend_throw_error

  adamziel

  committed
  f739d9a

• Crash: Remove $_memset

  adamziel

  committed
  fd9eb0a

• Crash: Remove $___errno_location

  adamziel

  committed
  899dade

• Crash: Remove $getTempRet0

  adamziel

  committed
  5f4a967

• Crash: Remove $_testSetjmp

  adamziel

  committed
  b6cc0fe

• Crash: Remove $_longjmp

  adamziel

  committed
  7471b9e

• Crash: Remove $invoke_viii

  adamziel

  committed
  d60d0e4

• Crash: Remove $invoke_vii

  adamziel

  committed
  474c74f

• Crash: Remove $_zend_mm_alloc_small_slow

  adamziel

  committed
  ee26599

• Crash: Remoe $_zend_mm_alloc_large

  adamziel

  committed
  291255b

• Crash: Remove _free

  adamziel

  committed
  bc462af

• Crash: Remove $_zend_set_compiled_filename

  adamziel

  committed
  af061f8

• Crash: Remove $_zend_get_compiled_filename

  adamziel

  committed
  d82a149

• Crash: Remove $_zend_get_compiled_lineno

  adamziel

  committed
  737bcb0

• Crash: Remove $_zend_is_compiling

  adamziel

  committed
  0042c4c

• Crash: Remove $_zend_stop_lexing

  adamziel

  committed
  b5cd1ec

• Crash: Remove $_memchr

  adamziel

  committed
  8aabf57

• Crash: Remove $_zend_binary_strcasecmp

  adamziel

  committed
  f08b466

• Crash: Remove $_zend_get_called_scope

  adamziel

  committed
  d1780f6

• Crash: Remove $_strlen

  adamziel

  committed
  9e839e2

• Crash: Remove$_strcmp

  adamziel

  committed
  e04d6a1

• Crash: Remove $_get_binary_op

  adamziel

  committed
  8e64ec9

• Crash: Remove $_get_unary_op

  adamziel

  committed
  998f423

• Crash: Remove $$_zend_hash_index_find

  adamziel

  committed
  8b77ac2

• Crash: Remove $__zend_handle_numeric_str_ex

  adamziel

  committed
  5cb4b78

• Crash: Remove $_zend_ast_create_zval

  adamziel

  committed
  0082d93

• Crash: Remove $_rc_dtor_func]

  adamziel

  committed
  c6d9b55

• Crash: Remove $__zend_get_special_const

  adamziel

  committed
  53958ae

• Crash: Remove zend_is_executing

  adamziel

  committed
  7ae1478

• Crash: Remove

  adamziel

  committed
  5a30a35

• Crash: Remove $_zend_vm_stack_extend

  adamziel

  committed
  d423f11

• Crash: Remove _zend_error_noreturn

  adamziel

  committed
  e461945

• Crash: remove $__zend_hash_init

  adamziel

  committed
  c05b3ca

• Crash: remove $_zend_file_context_begin and zend_new_array

  adamziel

  committed
  de6e1cf

• Crash: remove $_setitimer

  adamziel

  committed
  8713b0f

• Crash: remove settimer

  adamziel

  committed
  dbdbf50

• Crash: remove $_zend_str_tolower_copy

  adamziel

  committed
  e3443ce

• Crash: remove f64-rem

  adamziel

  committed
  cbf1d71

• Crash: remove _zend_dval_to_lval_slow $_zend_get_type_by_const $_zend_strpprintf $_zend_strpprintf_unchecked

  adamziel

  committed
  38d904b

• Crash: _zend_zval_type_name $_zend_type_error $_zend_class_implements_interface $_zend_binop_error $_instanceof_function_slow

  adamziel

  committed
  22232df

• Crash: remove _zend_stack_init $_zend_stack_top $_zend_stack_del_top $_zend_stack_is_empty $_zend_vspprintf $_zend_vstrpprintf

  adamziel

  committed
  d44d2ae

• Crash: remove _get_filename_lineno $_zend_error $_zend_unmangle_property_name_ex $_zend_is_true $_zend_deprecated_function

  adamziel

  committed
  4739422

• Remove $_zend_param_must_be_ref

  adamziel

  committed
  a59c0dc

• Remove $_zend_param_must_be_ref

  adamziel

  committed
  a63969c

• Crash: remove _gc_protect $__zend_bailout $_zend_parse_arg_bool_weak $_zend_update_property_ex

  adamziel

  committed
  532e16a

• Crash: remove _zend_read_property_ex $_zend_is_iterable $_memcmp $_zend_hash_str_find

  adamziel

  committed
  f97e119

• Crash: Removed functions $__zend_new_array_0 $__zend_hash_iterators_remove $__zend_hash_index_find $_zend_undefined_offset $_zend_undefined_index $_zend_illegal_string_offset $_zend_use_resource_as…

  Show description for a5dce8e
  adamziel

  committed
  a5dce8e

• Crash: Removed functions $__zval_undefined_op2 $__zval_undefined_op1 $_zend_multibyte_get_encoding_name $_zend_multibyte_check_lexer_compatibility $_zend_multibyte_encoding_detector $_zend_multibyt…

  Show description for 4542046
  adamziel

  committed
  4542046

• Crash: Removed functions $_zend_string_hash_func $_gc_remove_from_buffer $_mult $_lshift $_zend_sigaction $_tolower $___uflow $_getint $___pthread_self_357 $___syscall_ret $___lock $___unlock $_llv…

  Show description for ef9415e
  adamziel

  committed
  ef9415e

• Crash: Removed functions $__is_numeric_string_ex $_zend_try_ct_eval_const $_zval_get_double_func $_get_active_function_or_method_name $_zend_get_callable_name_ex $_strtol

  adamziel

  committed
  e2cb34e

• Crash: Removed functions $_zval_get_long_func $_zend_is_callable_ex $__zendi_try_convert_scalar_to_number $_is_numeric_str_function $_strtoul $_out

  adamziel

  committed
  0d771e8

• Crash: Removed functions $_zend_binary_op_produces_error $_zend_parse_arg_long_weak $_zend_parse_arg_double_weak $___lctrans_impl $___lctrans $___strerror_l

  adamziel

  committed
  6edd810

• Crash: Removed functions $_zend_ast_evaluate2 $_printf $_pib_init2 $_zend_mm_gc $_zend_mm_panic $_strerror $_fprintf $_zend_mm_safe_error $_saveSetjmp $_zend_out_of_memory $_fwrite $_zend_mm_alloc_…

  Show description for cb84203
  adamziel

  committed
  cb84203

• Crash: Removed functions $_zend_add_member_modifier $_zend_throw_exception $_zend_resolve_non_class_name $_zend_hash_find_ptr_lc $_zend_hash_str_find_ptr_lc $_zend_resolve_class_name $_zend_type_to…

  Show description for ff8d458
  adamziel

  committed
  ff8d458

• Tighten the max_updates check

  adamziel

  committed
  3e2d2b4

• Crash: Removed functions $_zendlex

  adamziel

  committed
  718f0ac

• Crash: $_zend_negate_num_string

  adamziel

  committed
  3a85922

• Crash: Remove call to $_lex_scan

  adamziel

  committed
  9f438d2

• Crash: Remove almost all function calls from _lex_scan

  adamziel

  committed
  966cf5c

• Crash: Remove ALL function calls from inside _lex_scan

  adamziel

  committed
  6f569d3

• Crash: remove all functions other than _lex_scan

  adamziel

  committed
  18d3010

• Crash: Remove unused imports

  adamziel

  committed
  c95f094