Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ln 5 COPY dest required / suffix #4

Merged
merged 1 commit into from
Sep 5, 2022
Merged

ln 5 COPY dest required / suffix #4

merged 1 commit into from
Sep 5, 2022

Conversation

johnkennyuk
Copy link
Contributor

Dockerfile COPY syntax

johnkennyuk
johnkennyuk commented Sep 4, 2022
View reviewed changes
Copy link
Contributor Author

@johnkennyuk johnkennyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My recent attempt at building from the script failed because of the COPY ln in the Dockerfile not having a trailing / for the dest.

@adamziel
Copy link
Collaborator

adamziel commented Sep 5, 2022

Thank you @johnkennyuk!

@adamziel adamziel merged commit cd5b85d into WordPress:trunk Sep 5, 2022
adamziel added a commit that referenced this pull request Oct 5, 2022
@adamziel
Crash: Iteration #4 of remove_unused_functions
957f5b1
@Atten007 Atten007 mentioned this pull request Jul 18, 2023
Closed
@jdevalk jdevalk mentioned this pull request Feb 6, 2024
Closed
@rhildred rhildred mentioned this pull request May 1, 2024
Closed
bgrgicak pushed a commit that referenced this pull request Jun 2, 2024
@dd32
Include the admin kitchen sink for import (#1475)
88aaf42 
## What is this PR doing?

Similar to #1357, but taking a deeper cut at it, as import expects to be
run within an admin interface.

## What problem is it solving?

The following fatal will be triggered:
```
PHP Fatal error:  Uncaught Error: Call to undefined function wp_read_audio_metadata() in /wordpress/wp-admin/includes/image.php:2
Stack trace:
#0 /wordpress/wp-content/plugins/WordPress-Importer-master/class-wxr-importer.php(1067): wp_generate_attachment_metadata(821, '/wordpress/wp-c...')
#1 /wordpress/wp-content/plugins/WordPress-Importer-master/class-wxr-importer.php(861): WXR_Importer->process_attachment(Array, Array, 'https://raw.git...')
#2 /wordpress/wp-content/plugins/WordPress-Importer-master/class-wxr-importer.php(383): WXR_Importer->process_post(Array, Array, Array, Array)
#3 /internal/eval.php(20): WXR_Importer->import('/tmp/import.wxr')
#4 {main}
  thrown in /wordpress/wp-admin/includes/image.php on line 2
```

Fixes #1444 (Since found this issue)

## How is the problem addressed?

Including includes/admin.php which pulls in all admin-related
functionality, rather than just the cropping functionality.

Alternatively, this could've been done by selectively importing
`includes/media.php` as well as `includes/image.php`, but I anticipate
that core is likely to include other related admin functions.

## Testing Instructions

Note: This is an untested change.

Try running
https://playground.wordpress.net/builder/builder.html#{%22preferredVersions%22:{%22php%22:%228.0%22,%22wp%22:%22latest%22},%22phpExtensionBundles%22:[%22kitchen-sink%22],%22features%22:{%22networking%22:true},%22steps%22:[{%22step%22:%22login%22,%22username%22:%22admin%22,%22password%22:%22password%22},{%22step%22:%22importWxr%22,%22file%22:{%22resource%22:%22url%22,%22url%22:%22https://raw.githubusercontent.com/WordPress/theme-test-data/try/cors-accessible-images/themeunittestdata.wordpress.xml%22}}]}
@bgrgicak bgrgicak mentioned this pull request Aug 15, 2024
Closed
@burncrete burncrete mentioned this pull request Nov 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnkennyuk @adamziel