This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
Fix font paths #51
Merged
Fix font paths #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @aristath, curious what others think. Also I'm hoping we will be able to leverage https://core.trac.wordpress.org/ticket/46370#comment:53 so we can declare fonts via theme.json. |
|
Interesting approach! I think this works for now, though we'll need to remember to re-enqueue the actual |
westonruter
reviewed
Oct 7, 2021
functions.php
Outdated
Comment on lines
28
to
36
| src: url('" . get_theme_file_uri( 'assets/fonts/source-serif-pro/SourceSerif4Variable-Roman.ttf.woff2' ) . "') format('woff2'); | ||
| } | ||
|
|
||
| @font-face{ | ||
| font-family: 'Source Serif Pro'; | ||
| font-weight: 200 900; | ||
| font-style: italic; | ||
| font-stretch: normal; | ||
| src: url('" . get_theme_file_uri( 'assets/fonts/source-serif-pro/SourceSerif4Variable-Italic.ttf.woff2' ) . "') format('woff2'); |
There was a problem hiding this comment.
Why not just have the URL start with an assets/ relative path? See #57
There was a problem hiding this comment.
Small CSS files can be inlined (see #49 for example). If the style.css file gets inlined, relative paths are no longer relative to the style.css path but to the site's root - and in that case assets/ won't work.
aristath
force-pushed
the
fix/font-paths
branch
from
dc8fa6c to
ed1c480
Compare
|
Rebased the branch and there are no more conflicts 👍 |
Closed
jeffpaul
added a commit
to jeffpaul/twentytwentytwo
that referenced
this pull request
Nov 16, 2021
Note that some of the references below are not the only contributions (commits, PR review, helpful issue input, etc.) from these folks, but merely the first ones I encountered while reviewing items committed to `trunk` since the initial branch commit. @westonruter via WordPress#51 @ntwb via WordPress#73 @juricav via WordPress#113 @Sandstromer via WordPress#69 @jasmussen via WordPress#74 @melchoyce via WordPress#16 @Riyadh1734 via WordPress#182 @desrosj via WordPress#223 @beafialho via WordPress#172 @clucasrowlands via WordPress#171 @Otto42 via WordPress#28 @luminuu via WordPress#107 @felixarntz via WordPress#240
kjellr
added a commit
that referenced
this pull request
Nov 17, 2021
* add missing props to CONTRIBUTORS.md Note that some of the references below are not the only contributions (commits, PR review, helpful issue input, etc.) from these folks, but merely the first ones I encountered while reviewing items committed to `trunk` since the initial branch commit. @westonruter via #51 @ntwb via #73 @juricav via #113 @Sandstromer via #69 @jasmussen via #74 @melchoyce via #16 @Riyadh1734 via #182 @desrosj via #223 @beafialho via #172 @clucasrowlands via #171 @Otto42 via #28 @luminuu via #107 @felixarntz via #240 * add dotorg handles to CONTRIBUTORS.md * Fix Rich's WP.org username. Co-authored-by: Kjell Reigstad <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't assume that the theme will be in
wp-content/themes/twentytwentytwo. Some sites use a different folder for wp-content, they have themes in subfolders, they might rename the theme and so on.As a result, using URLs like
url('/wp-content/themes/twentytwentytwo/assets/fonts/source-serif-pro/SourceSerif4Variable-Roman.ttf.woff2')in the stylesheet has a potential to break things.A solution to that issue would be to add the font-face styles inline. This will allow us to use PHP to get the correct URL to the theme, and avoid breaking things.
Notes:
twentytwentytwo-stylefromget_template_directory_uri() . '/style.css'to an empty string (''). Since the stylesheet is completely empty and only contains the headers for the theme, loading it would be a waste of resources. Using an empty string allows us to inline styles usingwp_add_inline_style, without actually enqueueing a file.woff2files. Since we no longer support IE11, these are not needed (also see Remove .otf & .woff font-files #50)