Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Sync with WP trunk #223

Merged
merged 2 commits into from
Nov 10, 2021
Merged

Sync with WP trunk #223

merged 2 commits into from
Nov 10, 2021

Conversation

desrosj
Copy link
Contributor

@desrosj desrosj commented Nov 10, 2021

Description

This PR contains all the changes made during pre-commit review when merging into WordPress Core.

Discussion for these can be found in WordPress/wordpress-develop#1817.

@kjellr kjellr requested a review from jffng November 10, 2021 13:11
@jffng
Copy link
Collaborator

jffng commented Nov 10, 2021

Summarizing the changes for good measure:

  • Ensures every file ends with a newline
  • Fixes trailing comma in functions.php (Fix php compatibility and linting errors. #215)
  • Changes all instances of uppercase text to use text-transform instead (Make "ABOUT US" use the Gutenberg text case setting #218)
  • Fixes doc block for all function definitions
  • Removes function_exists calls for block patterns since the theme won't work with anything earlier than 5.9, and those functions were introduced in 5.5
  • Adds an php code opening to index.php to pass tests
  • Bumps version and changelog to 1.0

@jffng jffng merged commit 843eae4 into trunk Nov 10, 2021
@desrosj desrosj deleted the trac/sync branch November 15, 2021 20:10
jeffpaul added a commit to jeffpaul/twentytwentytwo that referenced this pull request Nov 16, 2021
Note that some of the references below are not the only contributions (commits, PR review, helpful issue input, etc.) from these folks, but merely the first ones I encountered while reviewing items committed to `trunk` since the initial branch commit.

@westonruter via  WordPress#51
@ntwb via WordPress#73
@juricav via WordPress#113
@Sandstromer via WordPress#69
@jasmussen via WordPress#74
@melchoyce via WordPress#16
@Riyadh1734 via WordPress#182
@desrosj via WordPress#223
@beafialho via WordPress#172
@clucasrowlands via WordPress#171
@Otto42 via WordPress#28
@luminuu via WordPress#107
@felixarntz via WordPress#240
kjellr added a commit that referenced this pull request Nov 17, 2021
* add missing props to CONTRIBUTORS.md

Note that some of the references below are not the only contributions (commits, PR review, helpful issue input, etc.) from these folks, but merely the first ones I encountered while reviewing items committed to `trunk` since the initial branch commit.

@westonruter via  #51
@ntwb via #73
@juricav via #113
@Sandstromer via #69
@jasmussen via #74
@melchoyce via #16
@Riyadh1734 via #182
@desrosj via #223
@beafialho via #172
@clucasrowlands via #171
@Otto42 via #28
@luminuu via #107
@felixarntz via #240

* add dotorg handles to CONTRIBUTORS.md

* Fix Rich's WP.org username.

Co-authored-by: Kjell Reigstad <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants