This repository has been archived by the owner on Jan 15, 2019. It is now read-only.
adjust opacity featured image for IE and Edge #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adjusting the opacity for browsers that do not support mix-blend-mode (mainly IE and Edge) to make the featured image partially visible
kjellr
approved these changes
Oct 28, 2018
There was a problem hiding this comment.
This looks great, @LittleBigThing! I added one tiny commit to darken the readability layer when people are using mix-blend-mode (I noticed that was a little lighter than last time I recorded it for some reason 🤷♂️).
I see what you mean about that removal of the grayscale filter on click in Edge. I tried adding a separate rule that specifically targeted that :focus state, but it didn't help. 😞 In any case, I think it's safe to pursue that bug separately.
Screenshots:
Chrome:
Edge
IE11
^ I also noticed that IE is placing the title incorrectly here, so I'll open a bug for that as well.
Thanks again for following this through until merge. Great work!
This was referenced Oct 28, 2018
kjellr
added a commit
that referenced
this pull request
Oct 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #121
Adjusting the opacity for browsers that do not support
mix-blend-mode(mainly IE and Edge) to make the featured image partially visible (otherwise blue rectangle).Works fine with the Customizer option for enabling/disabling the filter.
Note that there is still a small bug in Edge: when clicking the featured image in the post feed, the image is regains its color despite the
filter: grayscale(100%)on it. I am not sure how to fix this...IE11 does not support filtering so, there it is not an issue.