-
Notifications
You must be signed in to change notification settings - Fork 165
Conversation
proposed fix for the opacity of featured image layers for browser not supporting mix-blend-mode
Should fix #121 |
Will add some comments later |
adding comments in SASS (only) to clarify the styling inside @supports
Not sure about the conflicts, but the PR works as expected in IE and Edge (#121). Of course, the opacity can always be adjusted as needed. Accessibility testing is welcome. Also, some opinions about the effect. Personally, I like the single post version with the image as a background. The featured image in the post feed is trickier: there, the image is not meant to be a background image, so one could expect to see it more clearly. This is of course general comment, but is more pronounced for this fallback version as the effect is less clear and unique. Note: |
This is looking great, thanks @LittleBigThing! Here are some screenshots of my testing: Safari 12.0: Edge Internet Explorer Any idea why the post-feed versions for IE/Edge are so much lighter than the ones on the single post page? Are those missing a layer or something?
Yeah, I agree. It's a little weird, but it doesn't bother me too much. It's also worth noting that site authors will have the option to opt-out of these overlays entirely in case they consider it a problem (#284). As per the notes in #6, this should be fairly solid on the a11y front. The lightest color possible with these alternate overlays is actually darker than that of our usual overlays (which already passes WCAG AA). 👍 Once we sort out those merge conflicts (I'm happy to take a stab at it if you'd like — just let me know), and figure out why there's a lightness difference between the in-feed images and the single-post images, this should be good to go. Thanks again for seeing this issue through! 🙌 |
I am not sure why it looks the same on browsers that support
|
adding a dark layer for the featured images in the post feed for IE and Edge
Far from being a Github expert, I suppose that I better start all over to fix those conflicts over after the option of turning off the image filter will be merged (#327)? Or is there a better order to merge? :-) |
fixing the positioning of the site logo in IE
This reverts commit 43fdb79.
I don't think there will be issues, but I do think that #327 will be ready to go shortly, so let's hold off just to double check. 👍 |
Closing in favor of #375. |
Proposed fix for the opacity of featured image layers for browser not supporting mix-blend-mode
Looks good on Chrome and Safari, need to test on Edge and IE.