Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump minimum required WordPress version to 6.4 #1062

Merged
merged 4 commits into from
Mar 20, 2024
Merged

Bump minimum required WordPress version to 6.4 #1062

merged 4 commits into from
Mar 20, 2024

Conversation

mukeshpanchal27
Copy link
Member

Summary

Fixes #1056

@mukeshpanchal27 mukeshpanchal27 added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release labels Mar 19, 2024
@mukeshpanchal27 mukeshpanchal27 self-assigned this Mar 19, 2024
@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review March 19, 2024 09:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 19, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mukeshpanchal27 <[email protected]>
Co-authored-by: westonruter <[email protected]>
Co-authored-by: felixarntz <[email protected]>
Co-authored-by: thelovekesh <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

westonruter
westonruter approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but with one suggestion

plugins/speculation-rules/hooks.php Outdated Show resolved Hide resolved
felixarntz
felixarntz approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mukeshpanchal27, LGTM!

@mukeshpanchal27 mukeshpanchal27 merged commit 9e3e4dc into trunk Mar 20, 2024
37 checks passed
@mukeshpanchal27 mukeshpanchal27 deleted the fix/1056-bump-minimum-wp-version branch March 20, 2024 03:57
@felixarntz felixarntz changed the title Bump minimum required WP version to 6.4 Bump minimum required WordPress version to 6.4 Mar 20, 2024
@felixarntz felixarntz added this to the performance-lab 3.0.0 milestone Mar 20, 2024
@felixarntz felixarntz removed the no milestone PRs that do not have a defined milestone for release label Mar 20, 2024
@swissspidy swissspidy mentioned this pull request Mar 21, 2024
Merged
3 tasks
This was referenced Mar 21, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thelovekesh thelovekesh thelovekesh approved these changes

@felixarntz felixarntz felixarntz approved these changes

@westonruter westonruter westonruter approved these changes

@pbearne pbearne Awaiting requested review from pbearne pbearne is a code owner

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein adamsilverstein is a code owner

@joemcgill joemcgill Awaiting requested review from joemcgill joemcgill is a code owner

@swissspidy swissspidy Awaiting requested review from swissspidy

Assignees

@mukeshpanchal27 mukeshpanchal27

Labels
Infrastructure Issues for the overall performance plugin infrastructure [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
performance-lab 3.0.0
Development

Successfully merging this pull request may close these issues.

Bump minimum required WP version to 6.4
4 participants
@mukeshpanchal27 @westonruter @felixarntz @thelovekesh