Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump minimum required WP version to 6.4 #1056

Closed
mukeshpanchal27 opened this issue Mar 15, 2024 · 2 comments · Fixed by #1062
Closed

Bump minimum required WP version to 6.4 #1056

mukeshpanchal27 opened this issue Mar 15, 2024 · 2 comments · Fixed by #1062
Assignees
@mukeshpanchal27
Labels
Infrastructure Issues for the overall performance plugin infrastructure [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only [Type] Enhancement A suggestion for improvement of an existing feature
Milestone
performance-lab 3...

Comments

@mukeshpanchal27
Copy link
Member

For context on why I'm opening this issue, please see https://make.wordpress.org/performance/handbook/performance-lab/version-support-policy/. Specifically, the following:

"The Performance Lab plugin commits to supporting the latest stable version of WordPress core."

Since we use some WP 6.4 functions see #1048 (comment), I propose changing the minimum WP version set to 6.4. This way, we won't need to handle safeguard or old version compatibility code.
@mukeshpanchal27 mukeshpanchal27 added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only labels Mar 15, 2024
@mukeshpanchal27 mukeshpanchal27 self-assigned this Mar 15, 2024
@mukeshpanchal27 mukeshpanchal27 mentioned this issue Mar 15, 2024
Merged
3 tasks
@westonruter
Copy link
Member

As part of this, we can eliminate any wrappers for wp_trigger_error() since it was introduced in 6.4.

@westonruter westonruter added this to the PL Plugin 3.0.0 milestone Mar 15, 2024
@felixarntz
Copy link
Member

+1 to bumping the minimum requirement. Let's do it for 3.0, which is a good time to do it anyway.

@mukeshpanchal27 mukeshpanchal27 mentioned this issue Mar 19, 2024
Merged
@westonruter westonruter mentioned this issue Mar 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mukeshpanchal27 mukeshpanchal27

Labels
Infrastructure Issues for the overall performance plugin infrastructure [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
performance-lab 3.0.0
Development

Successfully merging a pull request may close this issue.

Bump minimum required WordPress version to 6.4 WordPress/performance
3 participants
@westonruter @felixarntz @mukeshpanchal27