Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrollbars for Windows browsers #5286

Closed
wants to merge 1 commit into from

Conversation

CoDinAIy
Copy link

Fixes

Fixes #5282 by @obulat

Description

This pull request fixes the issue where scrollbars were displayed unnecessarily in Windows browsers due to the use of overflow-y-scroll in default.vue and VModalContent.vue.

Before
image
After
image

Changes made:

  • In default.vue, replaced overflow-y-scroll with overflow-y-auto to ensure scrollbars are shown only when content overflows.
  • In VModalContent.vue, replaced overflow-y: scroll; with overflow-y: auto; to prevent always-visible scrollbars and allow them to appear only when needed.

Testing Instructions

  1. Run the application locally on a Windows machine.
  2. Navigate to the homepage.
  3. Ensure that scrollbars appear only when the content overflows, and they remain hidden when the content fits within the viewport.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@CoDinAIy CoDinAIy requested a review from a team as a code owner December 17, 2024 18:31
@CoDinAIy CoDinAIy requested review from obulat and dhruvkb December 17, 2024 18:31
@openverse-bot openverse-bot added 🧱 stack: frontend Related to the Nuxt frontend 🟩 priority: low Low priority and doesn't need to be rushed 🛠 goal: fix Bug fix 🕹 aspect: interface Concerns end-users' experience with the software labels Dec 17, 2024
@CoDinAIy CoDinAIy closed this Dec 17, 2024
@CoDinAIy CoDinAIy deleted the fix-scrolbar-issue branch December 17, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Scrollbar displayed even when element is not overflowing
2 participants