Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrollbar visibility issue on Windows browsers(replaced overflow-y: scroll with overflow-y: auto). #5285

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

Anuj012004
Copy link
Contributor

@Anuj012004 Anuj012004 commented Dec 17, 2024

Fixes

Fixes #5282 by @obulat

Description

This pull request fixes the issue where scrollbars were displayed unnecessarily in Windows browsers due to the use of overflow-y-scroll in default.vue and VModalContent.vue.

Testing Instructions

  1. Run the application on a Windows machine locally.
  2. Go to the homepage.
  3. Verify that scrollbars are only visible when the content exceeds the viewport size and remain hidden if the content fits perfectly within the viewport.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Anuj012004 Anuj012004 requested a review from a team as a code owner December 17, 2024 18:02
@Anuj012004 Anuj012004 requested review from obulat and dhruvkb December 17, 2024 18:02
@openverse-bot openverse-bot added 🧱 stack: frontend Related to the Nuxt frontend 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🟩 priority: low Low priority and doesn't need to be rushed 🛠 goal: fix Bug fix 🕹 aspect: interface Concerns end-users' experience with the software labels Dec 17, 2024
@obulat
Copy link
Contributor

obulat commented Dec 17, 2024

Hi, @Anuj012004, thank you for your PR! Could you update the PR description? Something like #5286 would be great.

@Anuj012004
Copy link
Contributor Author

Hi @obulat, I have updated the description. Is it okay now?

@Anuj012004
Copy link
Contributor Author

Hi [@obulat, @dhruvkb],

I accidentally cleared the original description in my PR (#5285) and replaced it with my own. Could you please confirm if it's okay or if I need to change it? Also, is there any way to recover the original description?

@dhruvkb
Copy link
Member

dhruvkb commented Dec 17, 2024

Hey @Anuj012004, the PR template should be populated by filling out the [placeholder] parts and checking off the task list [ ][x]. I'ved restored the original template that you can now properly fill out.

@obulat obulat removed the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Dec 17, 2024
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, @Anuj012004 ! It works well ✨

@obulat obulat merged commit 6ee44df into WordPress:main Dec 17, 2024
95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Scrollbar displayed even when element is not overflowing
4 participants