Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch the dark mode #5260

Merged
merged 2 commits into from
Dec 10, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/feat/feature-flags.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"dark_mode_ui_toggle": {
"status": {
"staging": "switchable",
"production": "disabled"
"production": "switchable"
Copy link
Member

@dhruvkb dhruvkb Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "enabled" now, not "switchable". Folks who do not want dark mode can choose light instead of toggling the feature flag.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thank you!

obulat marked this conversation as resolved.
Show resolved Hide resolved
},
"defaultState": "on",
"description": "Display the UI toggle to change the site color theme and respect system preferences.",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,8 @@ const handleClick = () => {
</script>

<template>
<!-- TODO: Populate the post permalink. -->
<VFeatureNotice
see-more-href="https://make.wordpress.org/openverse/"
see-more-href="https://make.wordpress.org/openverse/?p=2216"
krysal marked this conversation as resolved.
Show resolved Hide resolved
@click="handleClick"
>
{{ $t("notification.darkMode.text") }}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { computed } from "#imports"
import { computed } from "vue"

import { describe, expect, test, vi } from "vitest"
import { usePreferredColorScheme } from "@vueuse/core"
Expand Down
Loading