-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launch the dark mode #5260
Launch the dark mode #5260
Conversation
3cba979
to
b3f7ac4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, and the linked post cannot be accessed unless logged in 👍!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot this.
frontend/feat/feature-flags.json
Outdated
@@ -34,7 +34,7 @@ | |||
"dark_mode_ui_toggle": { | |||
"status": { | |||
"staging": "switchable", | |||
"production": "disabled" | |||
"production": "switchable" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be "enabled" now, not "switchable". Folks who do not want dark mode can choose light instead of toggling the feature flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch, thank you!
Latest k6 run output1
Footnotes
|
Description
This PR sets the feature flag to
switchable
, andon
by default both in production and in staging. It also adds the link to the draft announcement Make post.Testing Instructions
Run the app and see that the link leads to the draft post (maintainers only, you need to be logged int to see the draft). The theme switcher should be on by default.
Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin