Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch the dark mode #5260

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Launch the dark mode #5260

merged 2 commits into from
Dec 10, 2024

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Dec 9, 2024

Description

This PR sets the feature flag to switchable, and on by default both in production and in staging. It also adds the link to the draft announcement Make post.

Testing Instructions

Run the app and see that the link leads to the draft post (maintainers only, you need to be logged int to see the draft). The theme switcher should be on by default.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from a team as a code owner December 9, 2024 14:50
@obulat obulat requested review from krysal and dhruvkb December 9, 2024 14:50
@openverse-bot openverse-bot added 🧱 stack: frontend Related to the Nuxt frontend 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Dec 9, 2024
@obulat obulat added 🟧 priority: high Stalls work on the project or its dependents 🌟 goal: addition Addition of new feature 💻 aspect: code Concerns the software code in the repository and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Dec 9, 2024
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and the linked post cannot be accessed unless logged in 👍!

Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot this.

@@ -34,7 +34,7 @@
"dark_mode_ui_toggle": {
"status": {
"staging": "switchable",
"production": "disabled"
"production": "switchable"
Copy link
Member

@dhruvkb dhruvkb Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "enabled" now, not "switchable". Folks who do not want dark mode can choose light instead of toggling the feature flag.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thank you!

Copy link

github-actions bot commented Dec 9, 2024

Latest k6 run output1

     ✓ status was 200

     checks.........................: 100.00% ✓ 416      ✗ 0   
     data_received..................: 97 MB   403 kB/s
     data_sent......................: 55 kB   226 B/s
     http_req_blocked...............: avg=66.13µs  min=2.6µs    med=4.69µs   max=1.07ms   p(90)=130.79µs p(95)=283.63µs
     http_req_connecting............: avg=47.33µs  min=0s       med=0s       max=1.02ms   p(90)=92.01µs  p(95)=135.41µs
     http_req_duration..............: avg=204.66ms min=34.81ms  med=158.85ms max=1.37s    p(90)=386.83ms p(95)=422.4ms 
       { expected_response:true }...: avg=204.66ms min=34.81ms  med=158.85ms max=1.37s    p(90)=386.83ms p(95)=422.4ms 
   ✓ http_req_failed................: 0.00%   ✓ 0        ✗ 416 
     http_req_receiving.............: avg=170.84µs min=74.08µs  med=139.59µs max=938.26µs p(90)=287.89µs p(95)=347.04µs
     http_req_sending...............: avg=27.73µs  min=9.58µs   med=22.18µs  max=620.65µs p(90)=38.45µs  p(95)=67.66µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=204.46ms min=34.7ms   med=158.7ms  max=1.37s    p(90)=386.45ms p(95)=422.15ms
     http_reqs......................: 416     1.724092/s
     iteration_duration.............: avg=1.09s    min=568.35ms med=1.27s    max=2.44s    p(90)=1.41s    p(95)=1.78s   
     iterations.....................: 78      0.323267/s
     vus............................: 4       min=0      max=6 
     vus_max........................: 60      min=60     max=60

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR

@obulat obulat merged commit a9441f7 into main Dec 10, 2024
50 checks passed
@obulat obulat deleted the launch-dark-mode branch December 10, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🌟 goal: addition Addition of new feature 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants