-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed obsolete cache invalidation code from get_sources function #5050
Conversation
Hi @obulat, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, @dryruffian, thank you for your contribution ✨
Why did you need to remove documentation/pdm.lock
? If there's no important reason, it's better to remove this change from this PR.
On another note, I see you made the PR from the main
branch of your fork. In the future, it's best to create a new branch for your PRs.
@obulat |
Please go ahead and remove it - or let us know if you need help removing it. |
Hello @obulat, |
6c03772
to
6b941d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to have a number of extraneous changes in addition to the one described in #706, and the import for SearchContext
appears to have been changed to a module that does not exist. @dryruffian do you mind limiting the scope of changes to the removal of the cache validation code, and restoring the import to its original location?
Signed-off-by: Olga Bulat <[email protected]>
I removed the unrelated changes, and also rebased this branch onto the |
…ordPress#5050) * Remove obsolete cache invalidation code from get_sources function(fixes WordPress#706) * Revert unrelated changes Signed-off-by: Olga Bulat <[email protected]> --------- Signed-off-by: Olga Bulat <[email protected]> Co-authored-by: Olga Bulat <[email protected]>
Fixes
Fixes #706 by @dhruvkb
Description
The transitional cache invalidation code used for migrating to the new
cache format is no longer needed. This change simplifies the codebase
and removes unnecessary cache operations.
Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin