Remove transition code in search controller

[dhruvkb]

Problem

The code described in this snippet was transitionary and has served its utility. It should be removed.

openverse/api/api/controllers/search_controller.py

Lines 552 to 569 in 7e558ef

	try:
	sources = cache.get(key=source_cache_name)
	except ValueError:
	cache_fetch_failed = True
	sources = None
	logger.warning("Source cache fetch failed due to corruption")
	except ConnectionError:
	cache_fetch_failed = True
	sources = None
	logger.warning("Redis connect failed, cannot get cached sources.")
	if isinstance(sources, list) or cache_fetch_failed:
	sources = None
	try:
	# Invalidate old provider format.
	cache.delete(key=source_cache_name)
	except ConnectionError:
	logger.warning("Redis connect failed, cannot invalidate cached sources.")

Description

This cache invalidation snippet has definitely run in production and the caches have surely been migrated to the new format. This should no longer be a part of the codebase.

Alternatives

Even in the highly unlikely event that the caches have not been cleared and updated, a better solution would be to use try...except to handle invalid values rather than using a very specific transition state.

Additional context

The issue originally pointed to this code snippet from the now-deprecated and archived WordPress/openverse-api repo
https://github.com/WordPress/openverse-api/blob/6cc0551c639081f895d974b30cc465713d0ce360/api/catalog/api/controllers/search_controller.py#L379-L387

Implementation

• 🙋 I would be interested in implementing this feature.

[sarayourfriend]

Can we check the production cache to confirm this is safe?

[dhruvkb]

@sarayourfriend given how long this has existed in the code, it's safe to assume this code has executed at least once, but yeah we can check the cache once and verify.

[sarayourfriend]

@dhruvkb can you update this issue with a new link for the monorepo code? At a glance, I think I understand what would need to be removed, but the issue is old enough and the link is to the archive repo, so my confidence that I can understand it is low (which doesn't bode well for many other people outside the team 😅).

[dhruvkb]

@sarayourfriend, done.

[dryruffian]

Hey @dhruvkb, I'd like to work on this issue. Can you please assign it to me?

[dhruvkb]

Sure, please go ahead!

[dryruffian]

Thanks, @dhruvkb. I'm on it!