Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #617 by @obulat
Description
This PR adds comments to the i18n strings that are used inside a full sentence:
This allows the translators to correctly select the word forms that match the full sentence.
It would be great if we could automate the creation of such comments, but I didn't find an easy way of doing that.
Still, having such comments is very important for accurate translations.
Testing Instructions
Run the app locally using
just frontend/run dev
You should not see any warnings about i18n keys missing in the console on any page of the site.
Also, look through the strings and see check that the comments look correct.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin