Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting of PR ping Slack messages #3653

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Conversation

krysal
Copy link
Member

@krysal krysal commented Jan 11, 2024

Fixes

Follow up #3577 and #3651

Description

Last notification of new PR received has bad formatting.

CleanShot 2024-01-11 at 14 50 49@2x

This is a quick PR to fix it, removing leftovers of when the action used curl calls.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@krysal krysal added 🟩 priority: low Low priority and doesn't need to be rushed 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: mgmt Related to repo management and automations labels Jan 11, 2024
@krysal krysal requested a review from a team as a code owner January 11, 2024 18:54
@sarayourfriend
Copy link
Collaborator

sarayourfriend commented Jan 11, 2024

The PR limit reminders job is also failing. I'll look into it now.

Fix for that here: #3657

@sarayourfriend sarayourfriend mentioned this pull request Jan 11, 2024
5 tasks
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some spaces between the words are missing, except that it LGTM!

.github/workflows/pr_ping.yml Show resolved Hide resolved
.github/workflows/pr_ping.yml Show resolved Hide resolved
.github/workflows/pr_ping.yml Outdated Show resolved Hide resolved
@krysal krysal force-pushed the fix/slack-gh-formatting branch from afb713e to 348088c Compare January 15, 2024 14:20
@krysal krysal merged commit 6e8b73e into main Jan 15, 2024
37 checks passed
@krysal krysal deleted the fix/slack-gh-formatting branch January 15, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: mgmt Related to repo management and automations
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants