-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced cURL
slack workflows with slackapi
#3577
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and thanks for the contribution! Can you run the linting (just lint
) locally and commit the changes? That way this will pass CI and we'll be able to merge it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution and agree with @sarayourfriend about linting. Just wanted to bring your attention to the file you possibly missed: https://github.com/WordPress/openverse/blob/ca35fa5f23d05575e78774ddc9a58c1b671aca2a/.github/workflows/pr_limit_reminders.yml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a new line at the end of each file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the continue to collaborate on this @The5cheduler! The code needs some additional work to fix the errors. I've labelled them in 2 files but the changes will apply to all 3.
I'm sorry we focused more on fixing linting issues before actual problems.
uses: slackapi/[email protected] | ||
with: | ||
payload: | | ||
{"user": "'"$slack_id"'","message": "'"$msg"'"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here $msg
is not defined. You can copy the message text from before and paste it here. Also the payload is regular YAML so the quote interpolations "'"
are not needed here.
{"user": "'"$slack_id"'","message": "'"$msg"'"} | |
{ | |
"user": "${{ env.slack_id }}", | |
"message": "<actual message from before>" | |
} |
Also the same note about environment variables as the other review comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @The5cheduler 🙏 It all looks good except on significant but easy to miss detail about how GitHub Action variables work. I've left a comment explaining the required change, and then this should be good-to-go, I think 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant, thank you @The5cheduler 🎉
Based on the low urgency of this PR, the following reviewers are being gently reminded to review this PR: @obulat Excluding weekend1 days, this PR was ready for review 6 day(s) ago. PRs labelled with low urgency are expected to be reviewed within 5 weekday(s)2. @The5cheduler, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic, @The5cheduler. Thank you!
Fixes
Fixes #3461 by @dhruvkb
Description
replaced the cURL with slackapi for github-actions to make it more aligned and maintainable.
Testing Instructions
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin