Use fully qualified docker image names

[ashiramin]

Fixes

Fixes #3023 by @sarayourfriend

Description

Use fully qualified image names in Dockerfiles and docker-compose files where relevant. Prefixed docker.io docker images being pulled from default docker registry

Testing Instructions

• Run docker system prune -a --volumes this is a bit destrutive as it will remove all local images and volumes but it will ensure no images from the cache are used.
• run just api/up && just api/init
• Go to http://0.0.0.0:50270/v2 to verify page loads up
• just frontend/build-img to verify FE image builds correctly as it seems line just frontend/run runs frontend outside of docker

Checklist

• My pull request has a descriptive title (not a vague title likeUpdate index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.
• I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[ashiramin]

@sarayourfriend do you know how to rerun CI CD pipeline one of the test is faling. The same tests failed when I first made the changes but rerunning it fixed it. I'm guessing the test are flaky. On the UI I am not able to find an option to rerun the test but I could on my forked repo

[dhruvkb]

@ashiramin the test that has failed could be a flake. I've triggered a re-run of the test which should pass now. GitHub does not allow contributors to re-run CI jobs but it's not a problem, one of the maintainers can do it.

[ashiramin]

@dhruvkb thank you

[dhruvkb]

I don't have any authoritative sources on FQIN, but this document from Windsock suggests that the FQIN should be like so:

- python
+ index.docker.io/library/python

As this is, the PR works and it's still more "qualified" than it used to be so I'm approving it but maybe the other reviewers can double-check.

[obulat]

As this is, the PR works and it's still more "qualified" than it used to be so I'm approving it but maybe the other reviewers can double-check.

I searched for both docker.io/python and docker.io/library/python in GitHub, and both are widely used. pypa uses docker.io/python, so I think it should be fine :)

[dhruvkb]

@obulat did you also see any usage of index. in the domain?

[AetherUnbound]

LGTM, this builds great locally even without purging the cache! Thanks for the contribution @ashiramin! 😄

[AetherUnbound]

Since docker.io works without the index. subdomain, I'm going to go ahead and merge this!