Transfer UUID validation inside serializer

[dhruvkb]

Description

This PR prevents the oEmbed endpoint from crashing when an invalid UUID is encountered. The UUID is now validated in the serializer, leading to DRF's ValidationError being raised if invalid. This is handled by DRF and converted to a 400 Bad Request reponse.

Earlier, Django would validate the UUID and raise a Django core ValidationError which does not map to a 400 response, and bubbles uncaught till it exits the worker.

Testing Instructions

0. Check out the PR and run the dev server.
1. Visit the oEmbed endpoint http://localhost:50280/v1/images/oembed/?url= with the following url values:
   • valid and existing UUID like 2982c0bf-9c26-4543-a712-4d50a117ded8
   • URL containing valid and existing UUID like https://abc.xyz/def/2982c0bf-9c26-4543-a712-4d50a117ded8
   • valid but non-existent UUID like f6e28bad-860d-4cab-980f-de5aa79892d2
   • invalid UUID like f6e28bad-860d-4cab-980f-de5aa79
2. In all cases you should see a DRF page with a proper error message and not the Django error page.

The PR also adds a test case checking for 400 response (before the PR the test would fail because the code would be 500).

Checklist

• My pull request has a descriptive title (not a vague title likeUpdate index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.
• I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[AetherUnbound]

LGTM and changes work locally, thanks for the quick turnaround on this!

[stacimc]

LGTM!

[krysal]

I find it odd that the URL validator is returning the image identifier.

[AetherUnbound]

This seems to just be the way this parameter is set up - ultimately we want an identifier out of it, even if the parameter itself is the url field.

[krysal]

It's confusing since it doesn't even check if value is a valid URL or not. I'd like us to go with this alternative solution.

[stacimc]

It is for sure confusing that it doesn't check if value is a valid URL, but http://localhost:50280/v1/images/oembed/?url=2982c0bf-9c26-4543-a712-4d50a117ded8 for example works on main and on this branch but not on the proposed alternative. Given this is critical, do we know we want to make that change in behavior as part of the fix? FWIW I agree it makes more sense in general, but worth asking.

Dismissing to unblock