Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout of filtered index creation action #2985

Merged
merged 1 commit into from
Sep 5, 2023
+2 −0
Merged

Increase timeout of filtered index creation action #2985

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ingestion_server/ingestion_server/indexer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,6 +525,8 @@ def create_and_populate_filtered_index(
# 10k derived from in-production testing
# See https://github.com/WordPress/openverse/issues/2963
requests_per_second=15_000,
# Temporary workaround to allow the action to complete.
request_timeout=48 * 3600,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the factorisation a bit weird.

Suggested change
request_timeout=48 * 3600,
request_timeout=2 * 24 * 60 * 60,

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's funny because I copied your own style to keep it even! 😆 I think I like more this short form.

openverse/ingestion_server/ingestion_server/es_helpers.py

Line 72 in e061bbc

timeout=timeout * 3600, # seconds

)

self.refresh(index_name=destination_index, change_settings=True)
Expand Down