-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase timeout of filtered index creation action #2985
Conversation
32862e0
to
8e8a319
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -525,6 +525,8 @@ def create_and_populate_filtered_index( | |||
# 10k derived from in-production testing | |||
# See https://github.com/WordPress/openverse/issues/2963 | |||
requests_per_second=15_000, | |||
# Temporary workaround to allow the action to complete. | |||
request_timeout=48 * 3600, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find the factorisation a bit weird.
request_timeout=48 * 3600, | |
request_timeout=2 * 24 * 60 * 60, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's funny because I copied your own style to keep it even! 😆 I think I like more this short form.
timeout=timeout * 3600, # seconds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes
Related to #2980 by @AetherUnbound and to #2975 by @sarayourfriend
Description
Quick workaround for letting the action complete in conjunction with #2975.
Testing Instructions
It shouldn't affect the current test suite.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin