Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout of filtered index creation action #2985

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

krysal
Copy link
Member

@krysal krysal commented Sep 5, 2023

Fixes

Related to #2980 by @AetherUnbound and to #2975 by @sarayourfriend

Description

Quick workaround for letting the action complete in conjunction with #2975.

Testing Instructions

It shouldn't affect the current test suite.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@krysal krysal requested a review from a team as a code owner September 5, 2023 02:15
@krysal krysal requested review from dhruvkb and sarayourfriend and removed request for a team September 5, 2023 02:15
@github-actions github-actions bot added the 🧱 stack: ingestion server Related to the ingestion/data refresh server label Sep 5, 2023
@openverse-bot openverse-bot added the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Sep 5, 2023
@krysal krysal added 🟧 priority: high Stalls work on the project or its dependents 🧰 goal: internal improvement Improvement that benefits maintainers, not users 💻 aspect: code Concerns the software code in the repository and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Sep 5, 2023
Base automatically changed from add/throttle-reindex to main September 5, 2023 05:25
@krysal krysal force-pushed the hotfix/incr_reindex_timeout branch from 32862e0 to 8e8a319 Compare September 5, 2023 15:16
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -525,6 +525,8 @@ def create_and_populate_filtered_index(
# 10k derived from in-production testing
# See https://github.com/WordPress/openverse/issues/2963
requests_per_second=15_000,
# Temporary workaround to allow the action to complete.
request_timeout=48 * 3600,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the factorisation a bit weird.

Suggested change
request_timeout=48 * 3600,
request_timeout=2 * 24 * 60 * 60,

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's funny because I copied your own style to keep it even! 😆 I think I like more this short form.

timeout=timeout * 3600, # seconds

Copy link
Collaborator

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@krysal krysal merged commit e84dc22 into main Sep 5, 2023
@krysal krysal deleted the hotfix/incr_reindex_timeout branch September 5, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: ingestion server Related to the ingestion/data refresh server
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants