Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap usage of useSensitiveMedia with computed #2982

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Wrap usage of useSensitiveMedia with computed #2982

merged 2 commits into from
Sep 5, 2023

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Sep 5, 2023

Fixes

Fixes #2927 by @obulat

Description

This PR wraps usages of the useSensitiveMedia composable with computed so that the value of shouldBlur is updated with the prop audio changes.

Testing Instructions

Try to reproduce the problem in the linked issue. If you are unable to, consider the issue fixed.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb requested a review from a team as a code owner September 5, 2023 00:14
@github-actions github-actions bot added the 🧱 stack: frontend Related to the Nuxt frontend label Sep 5, 2023
@openverse-bot openverse-bot added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Sep 5, 2023
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Size Change: +78 B (0%)

Total Size: 891 kB

Filename Size Change
./frontend/.nuxt/dist/client/app.js 127 kB +33 B (0%)
./frontend/.nuxt/dist/client/app.modern.js 118 kB +45 B (0%)
ℹ️ View Unchanged
Filename Size
./frontend/.nuxt/dist/client/275.js 343 B
./frontend/.nuxt/dist/client/275.modern.js 346 B
./frontend/.nuxt/dist/client/276.js 1.85 kB
./frontend/.nuxt/dist/client/commons/app.js 90 kB
./frontend/.nuxt/dist/client/commons/app.modern.js 81 kB
./frontend/.nuxt/dist/client/commons/components/v-error-section/components/v-external-search-form/components/v-external-source-li/98a81936.js 5.18 kB
./frontend/.nuxt/dist/client/commons/components/v-error-section/components/v-external-search-form/components/v-external-source-li/98a81936.modern.js 5.62 kB
./frontend/.nuxt/dist/client/components/loading-icon.js 733 B
./frontend/.nuxt/dist/client/components/loading-icon.modern.js 734 B
./frontend/.nuxt/dist/client/components/table-sort-icon.js 514 B
./frontend/.nuxt/dist/client/components/table-sort-icon.modern.js 519 B
./frontend/.nuxt/dist/client/components/v-all-results-grid.js 6.62 kB
./frontend/.nuxt/dist/client/components/v-all-results-grid.modern.js 6.46 kB
./frontend/.nuxt/dist/client/components/v-audio-collection.js 4.4 kB
./frontend/.nuxt/dist/client/components/v-audio-collection.modern.js 4.28 kB
./frontend/.nuxt/dist/client/components/v-audio-list.js 1.32 kB
./frontend/.nuxt/dist/client/components/v-audio-list.modern.js 1.31 kB
./frontend/.nuxt/dist/client/components/v-audio-result.js 1 kB
./frontend/.nuxt/dist/client/components/v-audio-result.modern.js 996 B
./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.js 959 B
./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.modern.js 960 B
./frontend/.nuxt/dist/client/components/v-audio-track.js 5.68 kB
./frontend/.nuxt/dist/client/components/v-audio-track.modern.js 5.63 kB
./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.js 636 B
./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.modern.js 642 B
./frontend/.nuxt/dist/client/components/v-bone.js 632 B
./frontend/.nuxt/dist/client/components/v-bone.modern.js 635 B
./frontend/.nuxt/dist/client/components/v-box-layout.js 1.33 kB
./frontend/.nuxt/dist/client/components/v-box-layout.modern.js 1.33 kB
./frontend/.nuxt/dist/client/components/v-collection-header.js 1.31 kB
./frontend/.nuxt/dist/client/components/v-collection-header.modern.js 1.31 kB
./frontend/.nuxt/dist/client/components/v-content-link.js 1.07 kB
./frontend/.nuxt/dist/client/components/v-content-link.modern.js 1.06 kB
./frontend/.nuxt/dist/client/components/v-content-page.js 530 B
./frontend/.nuxt/dist/client/components/v-content-page.modern.js 534 B
./frontend/.nuxt/dist/client/components/v-content-report-button.js 492 B
./frontend/.nuxt/dist/client/components/v-content-report-button.modern.js 496 B
./frontend/.nuxt/dist/client/components/v-content-report-form.js 3.33 kB
./frontend/.nuxt/dist/client/components/v-content-report-form.modern.js 3.21 kB
./frontend/.nuxt/dist/client/components/v-content-report-popover.js 3.79 kB
./frontend/.nuxt/dist/client/components/v-content-report-popover.modern.js 3.67 kB
./frontend/.nuxt/dist/client/components/v-copy-button.js 3.99 kB
./frontend/.nuxt/dist/client/components/v-copy-button.modern.js 4 kB
./frontend/.nuxt/dist/client/components/v-copy-license.js 2.34 kB
./frontend/.nuxt/dist/client/components/v-copy-license.modern.js 2.31 kB
./frontend/.nuxt/dist/client/components/v-dmca-notice.js 793 B
./frontend/.nuxt/dist/client/components/v-dmca-notice.modern.js 797 B
./frontend/.nuxt/dist/client/components/v-error-image.js 2.51 kB
./frontend/.nuxt/dist/client/components/v-error-image.modern.js 2.47 kB
./frontend/.nuxt/dist/client/components/v-error-section.js 5.21 kB
./frontend/.nuxt/dist/client/components/v-error-section.modern.js 4.58 kB
./frontend/.nuxt/dist/client/components/v-external-search-form.js 4.09 kB
./frontend/.nuxt/dist/client/components/v-external-search-form.modern.js 3.44 kB
./frontend/.nuxt/dist/client/components/v-external-source-list.js 2.63 kB
./frontend/.nuxt/dist/client/components/v-external-source-list.modern.js 1.99 kB
./frontend/.nuxt/dist/client/components/v-full-layout.js 1.57 kB
./frontend/.nuxt/dist/client/components/v-full-layout.modern.js 1.57 kB
./frontend/.nuxt/dist/client/components/v-grid-skeleton.js 1.54 kB
./frontend/.nuxt/dist/client/components/v-grid-skeleton.modern.js 1.54 kB
./frontend/.nuxt/dist/client/components/v-hide-button.js 577 B
./frontend/.nuxt/dist/client/components/v-hide-button.modern.js 573 B
./frontend/.nuxt/dist/client/components/v-home-gallery.js 4.28 kB
./frontend/.nuxt/dist/client/components/v-home-gallery.modern.js 4.26 kB
./frontend/.nuxt/dist/client/components/v-homepage-content.js 1.82 kB
./frontend/.nuxt/dist/client/components/v-homepage-content.modern.js 1.79 kB
./frontend/.nuxt/dist/client/components/v-image-cell.js 1.96 kB
./frontend/.nuxt/dist/client/components/v-image-cell.modern.js 1.94 kB
./frontend/.nuxt/dist/client/components/v-image-grid.js 4.42 kB
./frontend/.nuxt/dist/client/components/v-image-grid.modern.js 4.3 kB
./frontend/.nuxt/dist/client/components/v-license-tab-panel.js 642 B
./frontend/.nuxt/dist/client/components/v-license-tab-panel.modern.js 650 B
./frontend/.nuxt/dist/client/components/v-load-more.js 1.17 kB
./frontend/.nuxt/dist/client/components/v-load-more.modern.js 1.07 kB
./frontend/.nuxt/dist/client/components/v-media-details.js 2.31 kB
./frontend/.nuxt/dist/client/components/v-media-details.modern.js 2.28 kB
./frontend/.nuxt/dist/client/components/v-media-details/pages/image/_id/index.js 3.79 kB
./frontend/.nuxt/dist/client/components/v-media-details/pages/image/_id/index.modern.js 3.67 kB
./frontend/.nuxt/dist/client/components/v-media-license.js 933 B
./frontend/.nuxt/dist/client/components/v-media-license.modern.js 940 B
./frontend/.nuxt/dist/client/components/v-media-reuse.js 2.99 kB
./frontend/.nuxt/dist/client/components/v-media-reuse.modern.js 2.97 kB
./frontend/.nuxt/dist/client/components/v-media-tag.js 416 B
./frontend/.nuxt/dist/client/components/v-media-tag.modern.js 420 B
./frontend/.nuxt/dist/client/components/v-media-tags.js 588 B
./frontend/.nuxt/dist/client/components/v-media-tags.modern.js 588 B
./frontend/.nuxt/dist/client/components/v-metadata.js 937 B
./frontend/.nuxt/dist/client/components/v-metadata.modern.js 939 B
./frontend/.nuxt/dist/client/components/v-modal.js 982 B
./frontend/.nuxt/dist/client/components/v-modal.modern.js 972 B
./frontend/.nuxt/dist/client/components/v-no-results.js 2.67 kB
./frontend/.nuxt/dist/client/components/v-no-results.modern.js 2.03 kB
./frontend/.nuxt/dist/client/components/v-radio.js 1 kB
./frontend/.nuxt/dist/client/components/v-radio.modern.js 1.01 kB
./frontend/.nuxt/dist/client/components/v-related-audio.js 824 B
./frontend/.nuxt/dist/client/components/v-related-audio.modern.js 740 B
./frontend/.nuxt/dist/client/components/v-related-images.js 805 B
./frontend/.nuxt/dist/client/components/v-related-images.modern.js 720 B
./frontend/.nuxt/dist/client/components/v-report-desc-form.js 977 B
./frontend/.nuxt/dist/client/components/v-report-desc-form.modern.js 980 B
./frontend/.nuxt/dist/client/components/v-row-layout.js 1.72 kB
./frontend/.nuxt/dist/client/components/v-row-layout.modern.js 1.73 kB
./frontend/.nuxt/dist/client/components/v-safety-wall.js 1.44 kB
./frontend/.nuxt/dist/client/components/v-safety-wall.modern.js 1.44 kB
./frontend/.nuxt/dist/client/components/v-scroll-button.js 891 B
./frontend/.nuxt/dist/client/components/v-scroll-button.modern.js 890 B
./frontend/.nuxt/dist/client/components/v-search-results-title.js 618 B
./frontend/.nuxt/dist/client/components/v-search-results-title.modern.js 623 B
./frontend/.nuxt/dist/client/components/v-single-result-controls.js 1.17 kB
./frontend/.nuxt/dist/client/components/v-single-result-controls.modern.js 1.17 kB
./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.js 1.02 kB
./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js 915 B
./frontend/.nuxt/dist/client/components/v-snackbar.js 1.07 kB
./frontend/.nuxt/dist/client/components/v-snackbar.modern.js 1.08 kB
./frontend/.nuxt/dist/client/components/v-sources-table.js 14.6 kB
./frontend/.nuxt/dist/client/components/v-sources-table.modern.js 14.6 kB
./frontend/.nuxt/dist/client/components/v-warning-suppressor.js 306 B
./frontend/.nuxt/dist/client/components/v-warning-suppressor.modern.js 311 B
./frontend/.nuxt/dist/client/pages/about.js 1.42 kB
./frontend/.nuxt/dist/client/pages/about.modern.js 1.42 kB
./frontend/.nuxt/dist/client/pages/audio/_id/index.js 10.6 kB
./frontend/.nuxt/dist/client/pages/audio/_id/index.modern.js 10.2 kB
./frontend/.nuxt/dist/client/pages/feedback.js 1.36 kB
./frontend/.nuxt/dist/client/pages/feedback.modern.js 1.36 kB
./frontend/.nuxt/dist/client/pages/image/_id/index.js 9.09 kB
./frontend/.nuxt/dist/client/pages/image/_id/index.modern.js 8.83 kB
./frontend/.nuxt/dist/client/pages/image/_id/report.js 4.99 kB
./frontend/.nuxt/dist/client/pages/image/_id/report.modern.js 4.73 kB
./frontend/.nuxt/dist/client/pages/index.js 6.41 kB
./frontend/.nuxt/dist/client/pages/index.modern.js 6.35 kB
./frontend/.nuxt/dist/client/pages/preferences.js 1.45 kB
./frontend/.nuxt/dist/client/pages/preferences.modern.js 1.45 kB
./frontend/.nuxt/dist/client/pages/privacy.js 1.25 kB
./frontend/.nuxt/dist/client/pages/privacy.modern.js 1.26 kB
./frontend/.nuxt/dist/client/pages/search-help.js 1.62 kB
./frontend/.nuxt/dist/client/pages/search-help.modern.js 1.61 kB
./frontend/.nuxt/dist/client/pages/search.js 4.77 kB
./frontend/.nuxt/dist/client/pages/search.modern.js 4.54 kB
./frontend/.nuxt/dist/client/pages/search/audio.js 504 B
./frontend/.nuxt/dist/client/pages/search/audio.modern.js 508 B
./frontend/.nuxt/dist/client/pages/search/image.js 462 B
./frontend/.nuxt/dist/client/pages/search/image.modern.js 462 B
./frontend/.nuxt/dist/client/pages/search/index.js 317 B
./frontend/.nuxt/dist/client/pages/search/index.modern.js 320 B
./frontend/.nuxt/dist/client/pages/search/model-3d.js 243 B
./frontend/.nuxt/dist/client/pages/search/model-3d.modern.js 247 B
./frontend/.nuxt/dist/client/pages/search/video.js 240 B
./frontend/.nuxt/dist/client/pages/search/video.modern.js 244 B
./frontend/.nuxt/dist/client/pages/sources.js 1.54 kB
./frontend/.nuxt/dist/client/pages/sources.modern.js 1.54 kB
./frontend/.nuxt/dist/client/runtime.js 2.97 kB
./frontend/.nuxt/dist/client/runtime.modern.js 2.97 kB
./frontend/.nuxt/dist/client/vendors/app.js 68.4 kB
./frontend/.nuxt/dist/client/vendors/app.modern.js 68.1 kB

compressed-size-action

Copy link
Collaborator

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a request for changes to the implementation to avoid issues with creating computeds inside of computeds.

@dhruvkb dhruvkb marked this pull request as draft September 5, 2023 01:34
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use the unref to allow for passing audio or ref<audio>.

I think that we only need the ref for global audio, because it's the only element in which the value of audio can change. For the other audio track components, audio stays the same throughout the lifetime of the component.

@dhruvkb
Copy link
Member Author

dhruvkb commented Sep 5, 2023

I made the changes and force-pushed 2219a4e (to overwrite d95c8a3), but that doesn't work at all. It needs more investigation.

Update: It works now, with the change pushed in 599b63f.

@dhruvkb dhruvkb marked this pull request as ready for review September 5, 2023 09:01
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Can the audio in VAudioThumbnail also change over the lifetime of the component? I thought that only VGlobalLayout's audio does.

@dhruvkb
Copy link
Member Author

dhruvkb commented Sep 5, 2023

Yeah, the thumbnail also needs to account for the audio change.

@dhruvkb dhruvkb merged commit adf4374 into main Sep 5, 2023
@dhruvkb dhruvkb deleted the usm_composable branch September 5, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

useSensitiveMedia composable doesn't update when media changes
4 participants