Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useSensitiveMedia composable doesn't update when media changes #2927

Closed
obulat opened this issue Aug 31, 2023 · 0 comments · Fixed by #2982
Closed

useSensitiveMedia composable doesn't update when media changes #2927

obulat opened this issue Aug 31, 2023 · 0 comments · Fixed by #2982
Assignees
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend

Comments

@obulat
Copy link
Contributor

obulat commented Aug 31, 2023

Description

The media sensitivity and blurring is not updated when the global media item changes.

Reproduction

  1. Go to staging.openverse.org/preferences and turn on the 3 sensitivity flags (including the `fake_sensitive`)
  2. Narrow the screen to mobile width and search for some audio.
  3. Play one of the "non-sensitive" audio items so that the global audio player appears. Then, click on one of the audio items that is blurred because it is sensitive.
  4. See error: the audio title is not blurred in the global audio player because the composable is still using the first audio item to detect sensitivity.
    Note: it works the other way around, too: if you first play a sensitive item, then all audio titles will be blurred in the global audio player, even if the items are not sensitive.

Screenshots

Kapture 2023-08-31 at 09 38 51

Additional context

To fix this, we should pass the media as a ref to the use-sensitive-media composable.
I set the priority to high because this must be fixed before rolling out the Frontend blurring of sensitive content project.

@obulat obulat added 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix labels Aug 31, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Aug 31, 2023
@obulat obulat added 🟧 priority: high Stalls work on the project or its dependents 🟨 priority: medium Not blocking but should be addressed soon 💻 aspect: code Concerns the software code in the repository 🧱 stack: frontend Related to the Nuxt frontend and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🟨 priority: medium Not blocking but should be addressed soon labels Aug 31, 2023
@obulat obulat moved this from 📋 Backlog to 📅 To do in Openverse Backlog Aug 31, 2023
@dhruvkb dhruvkb self-assigned this Sep 5, 2023
@github-project-automation github-project-automation bot moved this from 📅 To do to ✅ Done in Openverse Backlog Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants