Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add DEFAULT_FROM_EMAIL setting handling #677

Merged
merged 1 commit into from
May 4, 2022

Conversation

sarayourfriend
Copy link
Contributor

Fixes

Fixes #676 by @AetherUnbound

Description

Adds the setting from the issue.

Testing Instructions

🤷 Not sure how to test this locally. You could set the environment variable then use manage.py shell to check if it is set.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • [N/A] I added or updated tests for the changes I made (if applicable).
  • [N/A] I added or updated documentation (if applicable).
  • [N/A] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@sarayourfriend sarayourfriend requested a review from a team as a code owner May 4, 2022 19:16
@sarayourfriend sarayourfriend requested review from obulat and stacimc May 4, 2022 19:16
@openverse-bot openverse-bot added 💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP labels May 4, 2022
@@ -298,6 +298,7 @@
EMAIL_HOST_PASSWORD = config("EMAIL_HOST_PASSWORD", default="")
EMAIL_SUBJECT_PREFIX = "[noreply]"
EMAIL_USE_TLS = True
DEFAULT_FROM_EMAIL = config("DEFAULT_FROM_EMAIL", default="")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Django default is webmaster@localhost, did we want to mirror that here so it's more obvious when this isn't set?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I'd vote for this group of required email settings to not have defaults unless some parent setting was turned off.

if config("ENABLE_EMAIL", default=True, cast=bool):
    DEFAULT_FROM_EMAIL = config("DEFAULT_FROM_EMAIL")  # no default! This should be an error if you don't supply it
    # etc...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this!

Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping on this @sarayourfriend! This can be merged, but I like your suggestion about an ENABLE_EMAIL setting 💯

@sarayourfriend sarayourfriend merged commit 24d4b03 into main May 4, 2022
@sarayourfriend sarayourfriend deleted the add/default-from-setting branch May 4, 2022 21:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings does not respect DEFAULT_FROM_EMAIL
4 participants