Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Settings does not respect DEFAULT_FROM_EMAIL #676

Closed
1 task
AetherUnbound opened this issue May 3, 2022 · 0 comments · Fixed by #677
Closed
1 task

Settings does not respect DEFAULT_FROM_EMAIL #676

AetherUnbound opened this issue May 3, 2022 · 0 comments · Fixed by #677
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🟥 priority: critical Must be addressed ASAP 🔧 tech: django Requires familiarity with Django 🐍 tech: python Requires familiarity with Python

Comments

@AetherUnbound
Copy link
Contributor

Description

We recently tried setting the DEFAULT_FROM_EMAIL1 in the environment for the API, but the settings.py file doesn't make use of it. We need to add some logic to the settings.py file to allow the default to be overridden.

Additional context

Blocks the resolution of #506

Resolution

  • 🙋 I would be interested in resolving this bug.

Footnotes

  1. https://docs.djangoproject.com/en/4.0/ref/settings/#std:setting-DEFAULT_FROM_EMAIL ↩
@AetherUnbound AetherUnbound added good first issue New-contributor friendly help wanted Open to participation from the community 🐍 tech: python Requires familiarity with Python 💻 aspect: code Concerns the software code in the repository 🔧 tech: django Requires familiarity with Django 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP labels May 3, 2022
@sarayourfriend sarayourfriend mentioned this issue May 4, 2022
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🟥 priority: critical Must be addressed ASAP 🔧 tech: django Requires familiarity with Django 🐍 tech: python Requires familiarity with Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add DEFAULT_FROM_EMAIL setting handling WordPress/openverse-api
1 participant
@AetherUnbound