DataViews: Update usePostFields to accept postType
#67380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Feature] Extensibility
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ntsekouras
commented
Nov 28, 2024
| featuredImageField, | ||
| postTypeConfig.supports?.thumbnail && | ||
| currentTheme?.[ 'theme-supports' ]?.[ 'post-thumbnails' ] && | ||
| featuredImageField, | ||
| titleField, |
There was a problem hiding this comment.
I intentionally didn't add the post type supports for title here, as I need to investigate better how core lists (wp-admin) handles it and what we should do here.
Additionally it relates to the issue about layout fields I mentioned in the PR's description. Some layouts declare this as primary field.
There was a problem hiding this comment.
Can you add a TODO in the code so we don't forget? Let's ship this.
ntsekouras
added
the
[Type] Task
youknowriad
reviewed
Nov 28, 2024
|
Size Change: +64 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Nov 28, 2024
| featuredImageField, | ||
| postTypeConfig.supports?.thumbnail && | ||
| currentTheme?.[ 'theme-supports' ]?.[ 'post-thumbnails' ] && | ||
| featuredImageField, | ||
| titleField, | ||
| authorField, | ||
| statusField, | ||
| dateField, | ||
| slugField, |
There was a problem hiding this comment.
This one has a support key too.
There was a problem hiding this comment.
yes, you can check the different <PostTypeSupportCheck calls we have to find these.
There was a problem hiding this comment.
Hm.. the docs for supports don't say that.. Are you sure there is such support?
I saw we have a <PostTypeSupportCheck supportKeys="slug"> check, but I don't think it ever worked properly - unless there was such support in the past. Also I think the above code might not being used anywhere by quickly adding a breakpoint there. I'll check more to see if we can remove that code.
There was a problem hiding this comment.
I think you're right :)
youknowriad
reviewed
Nov 28, 2024
youknowriad
approved these changes
Nov 28, 2024
|
I see there's a |
oandregal
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Thanks! :)
I'm seeing some weirds things (quickedit not opening, click behavior for table) but they also happen in trunk. See report in core-editor slack channel.
im3dabasia
pushed a commit
to im3dabasia/gutenberg
that referenced
this pull request
Dec 4, 2024
Co-authored-by: ntsekouras <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: oandregal <[email protected]>
michalczaplinski
pushed a commit
that referenced
this pull request
Dec 5, 2024
Co-authored-by: ntsekouras <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: oandregal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #61084
This PR updates
usePostFieldsto accept postType and add some support checks to conditionally add some fields, like featured image.This surfaces some issues we need to solve regarding layouts using some fields that might not exist. For example to handle when we don't support
featured imagebutview.layout.mediaFieldis declared to show that. These should be handled in follow ups to iterate faster.Testing Instructions
wp.editor.unregisterEntityField( 'postType', 'page', 'author' );orwp.editor.unregisterEntityField( 'postType', 'post', 'author' );in the respective DataViews lists