Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: Fix featured image not appearing in pages dataviews #67562

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

youknowriad
Copy link
Contributor

Fix small regression introduced in #67380

What?

The featured image field was not appearing anymore in the site editor in the pages dataviews (list, quick edit...)
It was just a small typo.

Testing Instructions

1- Open the site editor and verify that featured image thumbnails appear in the pages list.

@youknowriad youknowriad added [Type] Bug An existing feature does not function as intended [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond labels Dec 4, 2024
@youknowriad youknowriad self-assigned this Dec 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: youknowriad <[email protected]>
Co-authored-by: oandregal <[email protected]>
Co-authored-by: jasmussen <[email protected]>
Co-authored-by: ntsekouras <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@youknowriad youknowriad enabled auto-merge (squash) December 4, 2024 10:23
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@oandregal
Copy link
Member

Tested with both TT5 and TT4, that have post-thumbnails enabled by default.

@oandregal oandregal added this to the Gutenberg 19.9 milestone Dec 4, 2024
@oandregal
Copy link
Member

Tagging it for 19.9 to match #67380

@youknowriad youknowriad merged commit e62f8b4 into trunk Dec 4, 2024
70 of 73 checks passed
@youknowriad youknowriad deleted the fix/featured-image-post-type-detection branch December 4, 2024 10:56
im3dabasia pushed a commit to im3dabasia/gutenberg that referenced this pull request Dec 4, 2024
michalczaplinski pushed a commit that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants