Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data views: Fix alignment of action items in list layout #66273

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Data views: Fix alignment of action items in list layout #66273

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
718c577
Data views: Fix alignment of action items in list layout
jameskoster Oct 21, 2024
3a2986e
Remove unused margin, use padding-inline-end
jameskoster Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/dataviews/src/dataviews-layouts/list/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ ul.dataviews-view-list {
flex-basis: min-content;
overflow: unset;
margin-inline: $grid-unit-10 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems from quick testing that this margin is no longer relevant and can be removed if you’d like.

padding-right: $grid-unit-05;
Copy link
Contributor

@stokesman stokesman Oct 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nit as from testing RTL, this gets changed to padding-left. Though using a logical property e.g. padding-inline-end would be nice, me thinks.


.components-button {
opacity: 1;
Expand Down
Loading