Data views: Fix alignment of action items in list layout #66273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -6 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
stokesman
approved these changes
Oct 21, 2024
| @@ -34,6 +34,7 @@ ul.dataviews-view-list { | |||
| flex-basis: min-content; | |||
| overflow: unset; | |||
| margin-inline: $grid-unit-10 0; | |||
There was a problem hiding this comment.
It seems from quick testing that this margin is no longer relevant and can be removed if you’d like.
| @@ -34,6 +34,7 @@ ul.dataviews-view-list { | |||
| flex-basis: min-content; | |||
| overflow: unset; | |||
| margin-inline: $grid-unit-10 0; | |||
| padding-right: $grid-unit-05; | |||
There was a problem hiding this comment.
Super nit as from testing RTL, this gets changed to padding-left. Though using a logical property e.g. padding-inline-end would be nice, me thinks.
|
Good suggestions, thank you ❤️ |
|
Flaky tests detected in 3a2986e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11457872397
|
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 22, 2024
Co-authored-by: jameskoster <[email protected]> Co-authored-by: stokesman <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 17e96c7 |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…6273) Co-authored-by: jameskoster <[email protected]> Co-authored-by: stokesman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Ensure action icon buttons in data views list layout are aligned with other actions buttons in the header and footer.
Why?
Visual polish.
Testing Instructions
In the screenshot below, the left is trunk, the right is this PR: