Fixed : Modal dialog: small improvement for elementShouldBeHidden #65941

vk17-starlord · 2024-10-08T10:12:40Z

Fix: Avoid redundant aria-hidden on elements with hidden attribute

This PR updates the elementShouldBeHidden function to skip applying aria-hidden="true" to elements that already have the hidden attribute, as they are already hidden from both visual and assistive technologies. This prevents unnecessary DOM manipulations and ensures cleaner, more efficient accessibility handling.
Changes:

Added a check for the hidden attribute in the function to avoid redundant aria-hidden application.

…dPress#65829

github-actions · 2024-10-08T10:12:54Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: vk17-starlord <[email protected]>
Co-authored-by: afercia <[email protected]>
Co-authored-by: up1512001 <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2024-10-08T10:13:05Z

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @vk17-starlord! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

packages/components/src/modal/aria-helper.ts

up1512001

Added one suggestion please check.

…return statement

up1512001

LGTM

up1512001 · 2024-10-11T05:16:55Z

@vk17-starlord can you please add this PR info to changelog.md, it will go under Unreleased > Bug Fixes
https://github.com/WordPress/gutenberg/blob/trunk/packages/components/CHANGELOG.md

afercia · 2024-10-11T07:51:34Z

packages/components/src/modal/aria-helper.ts

+			element.hasAttribute( 'aria-hidden' ) || // Skip elements marked as aria-hidden
+			element.hasAttribute( 'aria-live' ) || // Skip live regions
+			( role && LIVE_REGION_ARIA_ROLES.has( role ) )
+		) // Skip elements with live region roles


This comment should be moved to the appropriate line. However, I'd consider to remove all these comments because the code is pretty self-explanatory.

afercia · 2024-10-11T07:53:58Z

packages/components/CHANGELOG.md

@@ -3,7 +3,7 @@
 ## Unreleased

 ### Bug Fixes
-
+-   `Modal` : Modal dialog small improvement for elementShouldBeHidden - PR ([#65941](https://github.com/WordPress/gutenberg/pull/65941)).


The changelog entry should follow a specific format:

Please remove the space before the colon.

Please remove the - PR .

I'd consider to move the entry to the Enhancements section as it's not a bug fix.

afercia

Thank you @vk17-starlord from a code perspective lookks good to me.
I left two small comments to address minor things, please have a look when you have a chance.

vk17-starlord · 2024-10-11T08:32:40Z

@afercia have a look at latest commit , i have implemented the suggestions you gave

afercia

LGTM, can be merged after tests pass.

afercia

I spoke to soon. There's now a merge conflict in packages/components/CHANGELOG.md that needs to be solved.

vk17-starlord · 2024-10-12T14:52:03Z

@afercia anything left to be done from my side ?

afercia · 2024-10-14T08:08:56Z

@afercia anything left to be done from my side ?

@vk17-starlord yes: the changelog entry must be in the Unreleased section, under Enhancements. It was probably moved down when merging trunk. Thanks for your patience.

…to fix/Modal-dialog-#65829

vk17-starlord · 2024-10-14T11:10:28Z

@afercia done with changes !!

afercia

LGTM to me.
Thanks @vk17-starlord

…5941) * Fixed : Modal dialog: small improvement for elementShouldBeHidden #65829 * Refactor `elementShouldBeHidden` to combine all checks into a single return statement * Added : PR description in changelog.md * Removed comments from function and fixed changelog * Removed modal details from bug fixes and moved to enhancements * Add missing empty line to changelog. * moved : PR details to enhancement section * Add missing empty line to changelog. --------- Co-authored-by: vk17-starlord <[email protected]> Co-authored-by: afercia <[email protected]> Co-authored-by: up1512001 <[email protected]>

…rdPress#65941) * Fixed : Modal dialog: small improvement for elementShouldBeHidden WordPress#65829 * Refactor `elementShouldBeHidden` to combine all checks into a single return statement * Added : PR description in changelog.md * Removed comments from function and fixed changelog * Removed modal details from bug fixes and moved to enhancements * Add missing empty line to changelog. * moved : PR details to enhancement section * Add missing empty line to changelog. --------- Co-authored-by: vk17-starlord <[email protected]> Co-authored-by: afercia <[email protected]> Co-authored-by: up1512001 <[email protected]>

Fixed : Modal dialog: small improvement for elementShouldBeHidden Wor…

19f6c91

…dPress#65829

vk17-starlord requested a review from ajitbohra as a code owner October 8, 2024 10:12

github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Oct 8, 2024

vk17-starlord changed the title ~~Fixed : Modal dialog: small improvement for elementShouldBeHidden #65829~~ Fixed : Modal dialog: small improvement for elementShouldBeHidden Oct 8, 2024

up1512001 added [Type] Enhancement A suggestion for improvement. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Components /packages/components labels Oct 10, 2024

up1512001 reviewed Oct 10, 2024

View reviewed changes

packages/components/src/modal/aria-helper.ts Outdated Show resolved Hide resolved

up1512001 requested changes Oct 10, 2024

View reviewed changes

Refactor elementShouldBeHidden to combine all checks into a single …

c105ad6

…return statement

vk17-starlord requested a review from up1512001 October 10, 2024 07:35

up1512001 approved these changes Oct 11, 2024

View reviewed changes

Added : PR description in changelog.md

1f359cd

afercia reviewed Oct 11, 2024

View reviewed changes

afercia requested changes Oct 11, 2024

View reviewed changes

Removed comments from function and fixed changelog

c20a22b

vk17-starlord requested a review from afercia October 11, 2024 08:35

vk17-starlord and others added 2 commits October 11, 2024 14:31

Removed modal details from bug fixes and moved to enhancements

a16631b

Add missing empty line to changelog.

47d6ff1

afercia approved these changes Oct 11, 2024

View reviewed changes

afercia requested changes Oct 11, 2024

View reviewed changes

Merge branch 'trunk' into fix/Modal-dialog-#65829

0b8c530

Merge branch 'WordPress:trunk' into fix/Modal-dialog-#65829

249987d

vk17-starlord added 2 commits October 14, 2024 16:23

moved : PR details to enhancement section

ab50e42

Merge branch 'trunk' of https://github.com/vk17-starlord/gutenberg in…

8c2cd31

…to fix/Modal-dialog-#65829

Add missing empty line to changelog.

ed93710

afercia approved these changes Oct 14, 2024

View reviewed changes

afercia merged commit ff58388 into WordPress:trunk Oct 14, 2024
62 checks passed

github-actions bot added this to the Gutenberg 19.5 milestone Oct 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed : Modal dialog: small improvement for elementShouldBeHidden #65941

Fixed : Modal dialog: small improvement for elementShouldBeHidden #65941

vk17-starlord commented Oct 8, 2024 •

edited by up1512001

Loading

github-actions bot commented Oct 8, 2024 •

edited

Loading

github-actions bot commented Oct 8, 2024

up1512001 left a comment

up1512001 left a comment

up1512001 commented Oct 11, 2024

afercia Oct 11, 2024

afercia Oct 11, 2024

afercia left a comment

vk17-starlord commented Oct 11, 2024

afercia left a comment

afercia left a comment

vk17-starlord commented Oct 12, 2024

afercia commented Oct 14, 2024

vk17-starlord commented Oct 14, 2024

afercia left a comment

Fixed : Modal dialog: small improvement for elementShouldBeHidden #65941

Fixed : Modal dialog: small improvement for elementShouldBeHidden #65941

Conversation

vk17-starlord commented Oct 8, 2024 • edited by up1512001 Loading

github-actions bot commented Oct 8, 2024 • edited Loading

github-actions bot commented Oct 8, 2024

up1512001 left a comment

Choose a reason for hiding this comment

up1512001 left a comment

Choose a reason for hiding this comment

up1512001 commented Oct 11, 2024

afercia Oct 11, 2024

Choose a reason for hiding this comment

afercia Oct 11, 2024

Choose a reason for hiding this comment

afercia left a comment

Choose a reason for hiding this comment

vk17-starlord commented Oct 11, 2024

afercia left a comment

Choose a reason for hiding this comment

afercia left a comment

Choose a reason for hiding this comment

vk17-starlord commented Oct 12, 2024

afercia commented Oct 14, 2024

vk17-starlord commented Oct 14, 2024

afercia left a comment

Choose a reason for hiding this comment

vk17-starlord commented Oct 8, 2024 •

edited by up1512001

Loading

github-actions bot commented Oct 8, 2024 •

edited

Loading