Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed : Modal dialog: small improvement for elementShouldBeHidden #65941

Merged
merged 11 commits into from
Oct 14, 2024
Merged

Fixed : Modal dialog: small improvement for elementShouldBeHidden #65941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
19f6c91
Fixed : Modal dialog: small improvement for elementShouldBeHidden #65829
vk17-starlord Oct 8, 2024
c105ad6
Refactor `elementShouldBeHidden` to combine all checks into a single …
vk17-starlord Oct 10, 2024
1f359cd
Added : PR description in changelog.md
vk17-starlord Oct 11, 2024
c20a22b
Removed comments from function and fixed changelog
vk17-starlord Oct 11, 2024
a16631b
Removed modal details from bug fixes and moved to enhancements
vk17-starlord Oct 11, 2024
47d6ff1
Add missing empty line to changelog.
afercia Oct 11, 2024
0b8c530
Merge branch 'trunk' into fix/Modal-dialog-#65829
vk17-starlord Oct 11, 2024
249987d
Merge branch 'WordPress:trunk' into fix/Modal-dialog-#65829
vk17-starlord Oct 14, 2024
ab50e42
moved : PR details to enhancement section
vk17-starlord Oct 14, 2024
8c2cd31
Merge branch 'trunk' of https://github.com/vk17-starlord/gutenberg in…
vk17-starlord Oct 14, 2024
ed93710
Add missing empty line to changelog.
afercia Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

### Enhancements

- `Modal`: Modal dialog small improvement for elementShouldBeHidden ([#65941](https://github.com/WordPress/gutenberg/pull/65941)).
- `Tabs`: revamped vertical orientation styles ([#65387](https://github.com/WordPress/gutenberg/pull/65387)).

## 28.9.0 (2024-10-03)
Expand Down
1 change: 1 addition & 0 deletions packages/components/src/modal/aria-helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ export function elementShouldBeHidden( element: Element ) {
const role = element.getAttribute( 'role' );
return ! (
element.tagName === 'SCRIPT' ||
element.hasAttribute( 'hidden' ) ||
element.hasAttribute( 'aria-hidden' ) ||
element.hasAttribute( 'aria-live' ) ||
( role && LIVE_REGION_ARIA_ROLES.has( role ) )
Expand Down
Loading