Components: Cleanup unused ToggleGroupControl config values
#65456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I feel like a CHANGELOG entry isn't necessary here, but I'm happy to add one if anyone disagrees. |
|
Size Change: -133 B (-0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
tyxla
force-pushed
the
cleanup/unused-config-values
branch
from
5761750 to
96046db
Compare
ciampo
approved these changes
Sep 18, 2024
noisysocks
added
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Sep 23, 2024
Co-authored-by: tyxla <[email protected]> Co-authored-by: ciampo <[email protected]>
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 969c3a5 |
github-actions
bot
added
the
Backported to WP Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #43997
What?
While reviewing some code related to
ToggleGroupControlI spotted some unused config values and decided to clean them up.I found that there are more unused ones around, but I decided this is enough for a single PR, since I initially headed to clean up solely the
ToggleGroupControlones.Why?
They're unused and can just be removed:
toggleGroupControlBackgroundColor- updated to use the underlyingcontrolBackgroundColortoggleGroupControlBorderColor(previouslysegmentedControlBorderColor) - never used since creation in [Components]: Add SegmentedControl #31937toggleGroupControlBackdropBackgroundColor(previouslysegmentedControlBackdropBackgroundColor) - never used since creation in [Components]: Add SegmentedControl #31937toggleGroupControlBackdropBorderColor(previouslysegmentedControlBackdropBorderColor) - never used since creation in [Components]: Add SegmentedControl #31937toggleGroupControlButtonColorActive: (previouslysegmentedControlButtonColorActive) - never used since creation in [Components]: Add SegmentedControl #31937controlBoxShadow: no longer in use since Remove BaseField component #47911controlDestructiveBorderColor: no longer in use since Remove BaseField component #47911controlSurfaceColor- no longer in use after thetoggleGroupControlvalues were removed.controlTextActiveColor- never used since creation in [Components]: Add SegmentedControl #31937surfaceBackgroundSubtleColor- not in use since introduced in components: Remove wp-g2 from surface #31238As you can see, this also allowed us to remove the entire
TOGGLE_GROUP_CONTROL_PROPSobject.How?
I removed the unused ones and cleaned the code around a little bit.
Testing Instructions
Verify the removed config values aren't in use. There should be no visual/functional changes.
Testing Instructions for Keyboard
Same
Screenshots or screencast
None, this has no visual impact.