-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
components: Remove wp-g2 from surface #31238
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
[Package] Components
/packages/components
[Feature] Component System
WordPress component system
labels
Apr 27, 2021
Size Change: +90 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Apr 27, 2021
sarayourfriend
force-pushed
the
remove/wp-g2-surface
branch
from
April 27, 2021 14:58
dc7265c
to
c6942a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes wp-g2 from the surface component. This one is big because we had to remove the usage of
createToken
and replace it with function calls.How has this been tested?
Storybook and unit tests 🙂
Types of changes
Non-breaking changes
Checklist:
*.native.js
files for terms that need renaming or removal).