Zoom Out: Try a cursor change to zoom in #65286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
requested review from
draganescu,
getdave,
noisysocks,
jeryj and
ajlende
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This was referenced Sep 12, 2024
|
Size Change: +117 B (+0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
If we do this then we should remove the double click to exit behavior because there are too many ways to exit via the mouse. How do we exit via the keyboard? |
Can we have too many ways to do something?
The edit button on sections. The problem is, if there are no sections there's nothing to click, which is why I quite like #64169 |
I would be against this. I feel pretty strongly that it's a key interaction. |
Sure we can, paricularly since affordances are not infinite.
It is, but with a huge space to single click and a visual - which is also a minus - indicator I don't know double clicking is also needed. |
getdave
reviewed
Sep 16, 2024
There was a problem hiding this comment.
Cool experiment.
However, I think we should explore some other routes. It's quite unexpected to me that the cursor changes when i'm hovering over a section without undertaking any action.
Instead of having this dramatic cursor change let's explore making it more contextual:
- let's remove the cursor change on section hover.
- let's make it so if you click and hold on a "section" then the cursor changes to a "grab" (hand) and you can drag and drop the section. I think that's a natural and expected interaction.
I'm on the fence about change to "zoom in" when over the grey "canvas" area.
|
Noting that @scruffian is AFK for a bit so we need someone to take over on this one if we wish to pursue it. |
Good exploration, but I don't think it's necessary to pursue further currently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This experiments with changing the cursor and adding a click handler to the iframe to make it easier to escape zoom out.
Also tries out a move cursor on sections.
Why?
There are some cases where it's quite difficult for users to escape zoom out mode. This adds another affordance to make it easier to get back to edit mode.
How?
cursor: zoom-into the iframe when zoomed out. This required moving the scale calculation for the iframe from the html to the body, which could have other side effects.Testing Instructions
Testing Instructions for Keyboard
This change only impacts mouse users (I think?)
Screenshots or screencast
Screen.Recording.2024-09-12.at.15.47.00.mov