Zoom Out: Always go to edit mode when inserting a single block #64169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
changed the title
|
Size Change: +45 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
scruffian
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
scruffian
commented
Aug 1, 2024
| @@ -49,5 +49,5 @@ export function useZoomOut( zoomOut = true ) { | |||
| ) { | |||
| __unstableSetEditorMode( originalEditingMode.current ); | |||
| } | |||
| }, [ __unstableSetEditorMode, zoomOut, mode ] ); | |||
| }, [ __unstableSetEditorMode, zoomOut ] ); | |||
There was a problem hiding this comment.
Needed to stop zoom out from being triggered again.
There was a problem hiding this comment.
We can't omit dependencies from this array as it can cause unexpected side effects.
There was a problem hiding this comment.
Can you explain the conditions you were testing under that "triggered [zoom out] again"?
I've refactored the code so that the mode is not a required dependency but I'd like to verify this behaves as intended.
getdave
reviewed
Aug 14, 2024
There was a problem hiding this comment.
I like this behaviour. It feels right and there is clear user intent. I think we should try and land this.
Aside: I think with many of these types of interactions where we trying to infer user intent, we will only truly know whether it works when it's tested with lots of users.
Comment on lines
+1803
to
+1811
| // Let inserting a single block always trigger Edit mode. | ||
| if ( | ||
| action.type === 'INSERT_BLOCKS' && | ||
| action.blocks.length === 1 && | ||
| action.blocks[ 0 ].innerBlocks.length === 0 | ||
| ) { | ||
| return 'edit'; | ||
| } | ||
|
|
There was a problem hiding this comment.
I'm noting that in the line above the behaviour is conditionalised to navigation mode.
gutenberg/packages/block-editor/src/store/reducer.js
Lines 1799 to 1803 in 54269c0
This action will apply to all modes in all editors. Are we confident that's safe? Would it be better to limit the action to be in Zoom Out mode only?
Suggested change
| // Let inserting a single block always trigger Edit mode. | |
| if ( | |
| action.type === 'INSERT_BLOCKS' && | |
| action.blocks.length === 1 && | |
| action.blocks[ 0 ].innerBlocks.length === 0 | |
| ) { | |
| return 'edit'; | |
| } | |
| // Let inserting a single block always trigger Edit mode. | |
| if ( | |
| state === 'zoom-out' && // only applies in zoom out mode | |
| action.type === 'INSERT_BLOCKS' && | |
| action.blocks.length === 1 && | |
| action.blocks[ 0 ].innerBlocks.length === 0 | |
| ) { | |
| return 'edit'; | |
| } | |
|
@scruffian Do we still want to pursue this? |
|
I think there's still something useful in this idea, but I'm trying something else in #65286. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Switch to edit mode (i.e. close zoom out mode or navigation mode) when inserting a single block.
Why?
When users get dropped into Zoom Out mode (for example in #61489) this drops them back into normal editing mode without them needing to find the zoom out controls.
How?
Update the
editorModereducer to respond toINSERT_BLOCKS.Testing Instructions
Enable zoomed out view when selecting a pattern category in the main inserter.experiment.Screenshots or screencast
Screen.Recording.2024-08-01.at.16.04.03.mov