Block Editor: Remove the Shuffle block toolbar button #64954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
Mamaduka
commented
Aug 31, 2024
| @@ -106,7 +101,6 @@ export function PrivateBlockToolbar( { | |||
| isDefaultEditingMode: _isDefaultEditingMode, | |||
| blockType: selectedBlockClientId && getBlockType( _blockName ), | |||
| shouldShowVisualToolbar: isValid && isVisual, | |||
| rootClientId: blockRootClientId, | |||
There was a problem hiding this comment.
Unrelated change: This value hasn't been used since #19596.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -38 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
|
Connecting this PR to this issue for additional feedback and context: #62288 |
97 tasks
|
Hey @Mamaduka 👋 Would you be able to help write a dev note for this for the 6.7 release? We are planning to have this as part of a larger Miscellaneous Editor Updates note. We are hoping to get all drafts in by October 13th to leave some time for reviews before the RC1. All Dev Notes get tracked in #65784 so feel free to leave a note there or ping me directly :) Please let us know if you can assist with that. Thanks in advance :) |
fabiankaegy
added
the
Needs Dev Note
|
I don't know if this needs a dev note or a mention in one. We add/remove parts of UI controls all the time and don't publish dev notes. |
@Mamaduka I agree we don't do it very often for UI changes. But broadly speaking we should do it more often. And especially in this case where the shuffle button was quite prominently featured in the toolbar I'd expect this to be a feature every user has at least encountered a few times. So I personally do think a dev note (as a small note in the overall miscellaneous section ) would be nice :) But also happy to drop if if you feel strongly about it :) |
|
I always understood that dev notes are for changes that affect developers/consumers. I don't see how this UI change might affect them. It was never actionable for developers. |
|
Sounds good 👍 removing it from the list then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
See #63900.
PR removes the Shuffle block toolbar button from the block editors' default viewing mode.
Why?
It's a destructive action that shouldn't be this easy to get to.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast