-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't expose pattern shuffle feature when content has been edited #62288
Comments
Here's a quick video of my experience with the new shuffle feature. shuffle-patterns.mp4TLDR:
In my testing, I also discovered a bug with synced patterns that are included in the same pattern category as the pattern being shuffled. |
Pattern shuffling seems like a whimsical fun idea, and WP could always use a bit of those. It reminds me of the color palette randomizer. I'm not sure if it is still in the codebase and under Experiments? Perhaps shuffling and color randomizer could get a proposal for a separate plugin: Randomizer Experiments plugin or something? 🤔 |
It is still an experiment |
@MaggieCabrera i was under the impression it is included in WordPress 6.6? Is that incorrect? |
I mean the color randomizer |
The Color Randomizer is still there as an experiment.
I like this thought — Besides Canonical Block Plugins, we could have a Canonical Gutenberg Experiments Plugin :) |
For context, there was some experimentation to keep content as you shuffled but it was technically complex and is something to explore for future releases. Between undo and overall revisions, this isn't fully destructive in that content is totally lost. I don't know the technical details of what it would take to only show the button if a pattern isn't edited but I don't think there's a clear path there. Can we keep this open for more feedback and see how this goes in the beta period? |
I'd tend to agree with Anne, across undo and revisions (which are about to get more prominent), this is just another editing tool, and any changes you make you still have to confirm/save after the fact. Perhaps there's a different word than "shuffle" for this, because what it does is not random—maybe "Cycle patterns"? Longer term, however, I would love to see any pattern transformations carry over information as best possible—paragraph to paragraph, heading to heading, image to image, and that should work for this as well. These are not strong opinions. |
Noting that there's a PR underway to remove the shuffle feature, unless in zoom out: #64954 |
With that change I think we can close this for now |
WordPress 6.6 introduces a new feature that allows users to hit a "Shuffle" button in the toolbar of any inserted pattern. This shuffle button then replaces the entire pattern with other patterns that are in the same category.
This is a really cool and powerful feature because it makes it easy for someone to cycle though their options and find what they want to use.
But the feature has one large problem as it stands today in Gutenberg 18.5 RC1. The shuffle button doesn't just exist for newly inserted patterns before they are modified but it shows for any patterns on the page.
When a user clicks on the shuffle button after they have already entered/modified any of the content in the pattern, their content just gets replaced/overwritten with the default content stored in the pattern.
This is a very destructive action that should be prevented at all cost.
From my perspective, there are a few options we should look at before we ship WordPress 6.6:
The text was updated successfully, but these errors were encountered: