Button Block: Apply Stretch Styles Correctly #64770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @joecsmalley. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
force-pushed
the
button/stretch-style
branch
from
05cb5d5
to
e0f6a91
Compare
|
Size Change: +54 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
t-hamano
changed the title
|
This seems good to me, thanks for the careful research and attention. In case @tellthemachines has a chance to look, I'd defer to her! Otherwise 👍 👍 |
t-hamano
force-pushed
the
button/stretch-style
branch
from
e0f6a91
to
7683a26
Compare
tellthemachines
approved these changes
Oct 25, 2024
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52533
What?
This PR ensures that buttons are stretched correctly when "Stretch to fill" or "Stretch items" are applied.
Why?
When "Stretch to fill" or "Stretch items" is applied to the Buttons block, its child element (
.wp-block-button) is stretched by thealign-items: stretchstyle. However, the actual button is the.wp-block-button__linkelement inside it, and since this has thedisplay: inline-blockstyle, there is no visible change.As I've researched in this comment, it appears that the stretch option for the Button block never worked when it was first implemented.
How?
Make the actual button height/width 100%. This will make the actual button the same size as the flex layout child.
However, simply changing the height or width to 100% will not center the content inside when buttons of different heights are lined up:
I first thought of applying
display: inline-flexinstead ofinline-blockto center the content, but if it containsbrtags or inline formatting, it will cause an unintended layout:So I left it as
inline-blockand appliedalign-content:center. This CSS is now defined as available for block containers other than flex/grid layouts, and should be supported in major browsers (W3C link).Testing Instructions
Screenshots or screencast
Horizontal Layout
Vertical Layout