Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons have mismatched heights #52533

Closed
joecsmalley opened this issue Jul 11, 2023 · 6 comments · Fixed by #64770
Closed

Buttons have mismatched heights #52533

joecsmalley opened this issue Jul 11, 2023 · 6 comments · Fixed by #64770
Assignees
Labels
[Block] Buttons Affects the Buttons Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@joecsmalley
Copy link

Description

I built a page with 4 inline buttons on top. The text on two of them drops down to a second line so the buttons are of different heights. There used to be the option to adjust that but I don't see it any longer, or potentially it's been removed. It could be just me but I created a vanilla wordpress site with just gutenberg and still had the same issue. I can't imagine I'm the only one who thinks buttons all with matching heights is visually appealing. Any help would be apprieciated.

Step-by-step reproduction instructions

Create New Page > Create 4 buttons that display inline > Now how do you make them uniform?

Screenshots, screen recording, code snippet

Screen Shot 2023-07-11 at 3 35 10 PM

Environment info

Wordpress Version 6.2.2
Twenty Twenty Three Theme

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@jordesign jordesign added [Type] Enhancement A suggestion for improvement. [Block] Buttons Affects the Buttons Block labels Jul 12, 2023
@ethanclevenger91
Copy link

To clarify this issue -

  1. New WP install. TT3 theme. No Gutenberg plugin installed.
  2. New post
  3. Add button group
  4. Create a few buttons
  5. Disable wrapping at the button-group level
  6. Ensure at least one button has enough content to overflow to a second line, and at least one other button does not
  7. On the button group, set "Change vertical alignment" to "Stretch to fill"
  8. See buttons do not, in fact, stretch to fill.

Can be seen here

@ethanclevenger91
Copy link

To ensure this gets eyes, the tag should probably be updated to [Type] Bug. @jordesign is that something you're able to update?

@jordesign
Copy link
Contributor

Thanks for the additional testing @ethanclevenger91 - I've labeled this one as an enhancement - as the behaviour being reported is as expected (rather than a bug).

Introduce an option/control for managing/evening the height of blocks is a good suggestion - but would be considered an enhancement of the existing functionality.

@jennydupuy
Copy link
Contributor

In WP 6.5, this option still doesn't work for buttons, whereas it does for columns or rows.

@ethanclevenger91
Copy link

@jordesign I wouldn't really call this an enhancement. There's an alignment setting, and as @jennydupuy mentioned, it does what you would expect for columns and rows. It doesn't behave as expected for buttons. I would call this a bug, not an enhancement.

@t-hamano
Copy link
Contributor

t-hamano commented Apr 1, 2024

I tested this problem using Playground.

WP 6.1.5

https://playground.wordpress.net/?wp=6.1

The "Stretch to fill" option does not exist in either Buttons or Button blocks.

image

WP 6.2.4

https://playground.wordpress.net/?wp=6.2

image

A "Stretch to fill" option exists. Applying this option will align all buttons to the top.

WP 6.3.3, WP6.4.4, WP 6.5 RC4 and latest Gutenberg

https://playground.wordpress.net/?wp=6.3
https://playground.wordpress.net/?wp=6.4
https://playground.wordpress.net/?wp=beta

Applying this option will align all buttons to the top.

So I guess this option hasn't been working properly since it was first introduced in WP6.2. Therefore, I'm marking this issue as a bug.

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended and removed [Type] Enhancement A suggestion for improvement. labels Apr 1, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Buttons Affects the Buttons Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants