-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PluginDocumentSettingPanel in template inspector controls #60961
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -126,19 +126,15 @@ const SidebarContent = ( { tabName, keyboardShortcut, isEditingTemplate } ) => { | |
/> | ||
} | ||
/> | ||
{ ! isEditingTemplate && ( | ||
<> | ||
<PostStatus /> | ||
<PluginDocumentSettingPanel.Slot /> | ||
<PostLastRevisionPanel /> | ||
<PostTaxonomiesPanel /> | ||
<PostExcerptPanel /> | ||
<PostDiscussionPanel /> | ||
<PageAttributesPanel /> | ||
<PatternOverridesPanel /> | ||
<MetaBoxes location="side" /> | ||
</> | ||
) } | ||
{ ! isEditingTemplate && <PostStatus /> } | ||
<PluginDocumentSettingPanel.Slot /> | ||
<PostLastRevisionPanel /> | ||
<PostTaxonomiesPanel /> | ||
<PostExcerptPanel /> | ||
<PostDiscussionPanel /> | ||
<PageAttributesPanel /> | ||
<PatternOverridesPanel /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you think that all of these components being rendered for templates is fine? It probably is just want to confirm that it doesn't result in different UIs than trunk :) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. They were still rendered here: https://github.com/WordPress/gutenberg/pull/60961/files#diff-6139877d7164dad773ae6521334135a37eb7e0bb351ade4c4f2169aa69da6e34L137 in site editor, so it should be the same in post editor, since they have checks whether to render or not. The alternative would be to separate them in site editor too(the above linked code) and just remove them from there and keep them in PagePanels. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Additionally the revisions panel was rendered in site editor and now it does in post editor too. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Definitely worth unifying like you did. |
||
{ ! isEditingTemplate && <MetaBoxes location="side" /> } | ||
</Tabs.TabPanel> | ||
<Tabs.TabPanel tabId={ sidebars.block } focusable={ false }> | ||
<BlockInspector /> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unlike other post-type properties, the
wp_template
supports revisions, and unlike the trunk, this might result in revision panel rendering for templates.I think @ntsekouras answered my questions here -#60961 (comment).