Add PluginDocumentSettingPanel in template inspector controls #60961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
approved these changes
Apr 22, 2024
|
I actually didn't want to approve yet, we should first add the alternative to |
You're right! I added it. |
|
I think even in the post editor we need to relax a check to render |
|
Size Change: +126 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
I did that and also moved some panels to a lower level since we have checks for them. |
youknowriad
reviewed
Apr 23, 2024
| <PostExcerptPanel /> | ||
| <PostDiscussionPanel /> | ||
| <PageAttributesPanel /> | ||
| <PatternOverridesPanel /> |
There was a problem hiding this comment.
Do you think that all of these components being rendered for templates is fine? It probably is just want to confirm that it doesn't result in different UIs than trunk :)
There was a problem hiding this comment.
They were still rendered here: https://github.com/WordPress/gutenberg/pull/60961/files#diff-6139877d7164dad773ae6521334135a37eb7e0bb351ade4c4f2169aa69da6e34L137 in site editor, so it should be the same in post editor, since they have checks whether to render or not.
The alternative would be to separate them in site editor too(the above linked code) and just remove them from there and keep them in PagePanels.
There was a problem hiding this comment.
Additionally the revisions panel was rendered in site editor and now it does in post editor too.
There was a problem hiding this comment.
Definitely worth unifying like you did.
|
This is looking good. I'm guessing this is also a new API for the post editor :) (templates panels were only extensible in the site editor), so it's an enhancement. @Mamaduka any thoughts about this PR? |
Mamaduka
reviewed
Apr 23, 2024
| ) } | ||
| { ! isEditingTemplate && <PostStatus /> } | ||
| <PluginDocumentSettingPanel.Slot /> | ||
| <PostLastRevisionPanel /> |
There was a problem hiding this comment.
Unlike other post-type properties, the wp_template supports revisions, and unlike the trunk, this might result in revision panel rendering for templates.
I think @ntsekouras answered my questions here -#60961 (comment).
Mamaduka
approved these changes
Apr 23, 2024
ntsekouras
changed the title
ntsekouras
added
[Type] Enhancement
49 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR moves some panels around in order to be rendered for both posts and templates. That was already the case for most panels in site editor. The main addition is that
PluginDocumentSettingPanelis also rendered for templates too, so extenders can use this slot in this case.Additionally in this PR, but with the unification effort it has been suggested that we could use
PluginDocumentSettingPanelinstead.Technically we cannot use internally
PluginDocumentSettingPanelslot, because it checks if the panel is opened, which is false by default and that results in not showing the contents. The other difference is that this slot didn't render the PanelBody whereas PluginDocumentSettingPanel does. So we soft deprecates the PluginTemplateSettingPanel.Testing Instructions
PluginDocumentSettingPanel should also work for templates