Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-picked bug fixes for 6.5.1 #60577

Merged
merged 12 commits into from
Apr 9, 2024
Merged

Cherry-picked bug fixes for 6.5.1 #60577

merged 12 commits into from
Apr 9, 2024

Commits on Apr 9, 2024

  1. Font Library: Reset notices when navigating away from the collection (#…

    …59981)
    
    
    Co-authored-by: Mamaduka <[email protected]>
    Co-authored-by: mikachan <[email protected]>
    Co-authored-by: annezazu <[email protected]>
    Co-authored-by: madhusudhand <[email protected]>
    5 people authored and tellthemachines committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    f9a655d View commit details
    Browse the repository at this point in the history
  2. Pattern Explorer: Pass 'rootClientId' to the pattern list (#60014)

    Co-authored-by: Mamaduka <[email protected]>
    Co-authored-by: t-hamano <[email protected]>
    Co-authored-by: dsas <[email protected]>
    4 people authored and tellthemachines committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    b2a0853 View commit details
    Browse the repository at this point in the history
  3. Fix lightbox UI disallow editing (#59890)

    * Check that lightbox can be edited before rendering lightbox UI
    
    * Refactor to reduce duplicate code
    
    * Fix and clarify component rendering logic
    
    Fix issue wherein lightbox popover was rendering
    erroneously when a link had been configured.
    
    * Reset lightbox attributes when removing link
    
    * Show lightbox UI if block-level override differs from default
    
    In some cases, such as when lightbox settings already exist for
    a block when global lightbox settings in theme.json change, we
    should allow users to see the lightbox UI and change the settings
    if they conflict with the global settings, even if the lightbox UI
    is disabled globally. This prevents a block from getting stuck with
    legacy lightbox settings and allows users to reset the block-level
    lightbox settings if need be in these edge cases.
    
    Note: We do not display the UI if the block-level settings exist
    and match the global settings, as the block will behave as expected
    in those circumstances and showing the UI in those circumstances
    would likely just be confusing.
    
    * Handle edge case of removing existing link when lightbox is fully enabled
    
    * Fix focus loss preventing end-to-end test from passing
    
    * Add link to PR in comment
    
    Co-authored-by: artemiomorales <[email protected]>
    Co-authored-by: michalczaplinski <[email protected]>
    Co-authored-by: justintadlock <[email protected]>
    Co-authored-by: annezazu <[email protected]>
    Co-authored-by: gziolo <[email protected]>
    Co-authored-by: t-hamano <[email protected]>
    Co-authored-by: jeherve <[email protected]>
    8 people authored and tellthemachines committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    b54a426 View commit details
    Browse the repository at this point in the history
  4. Only show inserter in document tools if DFM is off (#60426)

    Co-authored-by: draganescu <[email protected]>
    Co-authored-by: youknowriad <[email protected]>
    
    * only show inserter in document tools if DFM is off
    
    * remove useless CSS hiding the inserter in DFM whcih is not rendered anymore
    draganescu authored and tellthemachines committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    e7eb576 View commit details
    Browse the repository at this point in the history
  5. Fix don't close overlay menu when focus leaves submenu (#60406)

    Co-authored-by: fabiankaegy <[email protected]>
    Co-authored-by: c4rl0sbr4v0 <[email protected]>
    Co-authored-by: Mamaduka <[email protected]>
    Co-authored-by: annezazu <[email protected]>
    5 people authored and tellthemachines committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    64b473e View commit details
    Browse the repository at this point in the history
  6. Fix experimental useHasRecursion deprecation (#60451)

    Unlinked contributors: albanyacademy.
    
    Co-authored-by: talldan <[email protected]>
    Co-authored-by: andrewserong <[email protected]>
    Co-authored-by: ramonjd <[email protected]>
    4 people authored and tellthemachines committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    94aa4f6 View commit details
    Browse the repository at this point in the history
  7. Fix pattern block recursion handling (#60452)

    - Trigger recursion short circuit as early as possible before any other effects
    that can reason about inner blocks have run.
    - Use separate wrapper components to do this to satisfy the rule of hooks.
    
    Co-authored-by: talldan <[email protected]>
    Co-authored-by: ramonjd <[email protected]>
    Co-authored-by: andrewserong <[email protected]>
    4 people authored and tellthemachines committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    6a417eb View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a6d850a View commit details
    Browse the repository at this point in the history
  9. Update the query block to permit non-core interactive blocks (#60006)

    * updated the query block to permit non-core interactive blocks
    
    * updated logic to correctly check all blocks inside the query support interactivity
    
    * removed check for core blocks
    
    * updated variable names and modal message per feedback
    
    * renamed variable blockSupportsInteractivityBool to blockSupportsInteractivity
    
    Unlinked contributors: poof86.
    
    Co-authored-by: colinduwe <[email protected]>
    Co-authored-by: cbravobernal <[email protected]>
    Co-authored-by: gziolo <[email protected]>
    Co-authored-by: sethrubenstein <[email protected]>
    Co-authored-by: colorful-tones <[email protected]>
    6 people authored and tellthemachines committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    79babed View commit details
    Browse the repository at this point in the history
  10. Add context to 'Library' string (#60520)

    Co-authored-by: ocean90 <[email protected]>
    Co-authored-by: t-hamano <[email protected]>
    3 people authored and tellthemachines committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    3503ced View commit details
    Browse the repository at this point in the history
  11. DateTimePicker: Change day button size back from 32px to 28px (#59990)

    * DateTimePicker: Change day button size back from 32px to 28px
    
    * Update changelog
    
    Co-authored-by: t-hamano <[email protected]>
    Co-authored-by: mirka <[email protected]>
    Co-authored-by: annezazu <[email protected]>
    Co-authored-by: getdave <[email protected]>
    5 people authored and tellthemachines committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    062f2ae View commit details
    Browse the repository at this point in the history
  12. Avoid overriding custom settings on font library save (#60438)

    Co-authored-by: matiasbenedetto <[email protected]>
    Co-authored-by: youknowriad <[email protected]>
    Co-authored-by: mikachan <[email protected]>
    Co-authored-by: creativecoder <[email protected]>
    Co-authored-by: desrosj <[email protected]>
    Co-authored-by: estelaris <[email protected]>
    Co-authored-by: YanCol <[email protected]>
    8 people authored and tellthemachines committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    927940e View commit details
    Browse the repository at this point in the history