Cherry-picked bug fixes for 6.5.1 #60577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…59981) Co-authored-by: Mamaduka <[email protected]> Co-authored-by: mikachan <[email protected]> Co-authored-by: annezazu <[email protected]> Co-authored-by: madhusudhand <[email protected]>
Co-authored-by: Mamaduka <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: dsas <[email protected]>
* Check that lightbox can be edited before rendering lightbox UI * Refactor to reduce duplicate code * Fix and clarify component rendering logic Fix issue wherein lightbox popover was rendering erroneously when a link had been configured. * Reset lightbox attributes when removing link * Show lightbox UI if block-level override differs from default In some cases, such as when lightbox settings already exist for a block when global lightbox settings in theme.json change, we should allow users to see the lightbox UI and change the settings if they conflict with the global settings, even if the lightbox UI is disabled globally. This prevents a block from getting stuck with legacy lightbox settings and allows users to reset the block-level lightbox settings if need be in these edge cases. Note: We do not display the UI if the block-level settings exist and match the global settings, as the block will behave as expected in those circumstances and showing the UI in those circumstances would likely just be confusing. * Handle edge case of removing existing link when lightbox is fully enabled * Fix focus loss preventing end-to-end test from passing * Add link to PR in comment Co-authored-by: artemiomorales <[email protected]> Co-authored-by: michalczaplinski <[email protected]> Co-authored-by: justintadlock <[email protected]> Co-authored-by: annezazu <[email protected]> Co-authored-by: gziolo <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: jeherve <[email protected]>
Co-authored-by: draganescu <[email protected]> Co-authored-by: youknowriad <[email protected]> * only show inserter in document tools if DFM is off * remove useless CSS hiding the inserter in DFM whcih is not rendered anymore
Co-authored-by: fabiankaegy <[email protected]> Co-authored-by: c4rl0sbr4v0 <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: annezazu <[email protected]>
Unlinked contributors: albanyacademy. Co-authored-by: talldan <[email protected]> Co-authored-by: andrewserong <[email protected]> Co-authored-by: ramonjd <[email protected]>
- Trigger recursion short circuit as early as possible before any other effects that can reason about inner blocks have run. - Use separate wrapper components to do this to satisfy the rule of hooks. Co-authored-by: talldan <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: andrewserong <[email protected]>
* updated the query block to permit non-core interactive blocks * updated logic to correctly check all blocks inside the query support interactivity * removed check for core blocks * updated variable names and modal message per feedback * renamed variable blockSupportsInteractivityBool to blockSupportsInteractivity Unlinked contributors: poof86. Co-authored-by: colinduwe <[email protected]> Co-authored-by: cbravobernal <[email protected]> Co-authored-by: gziolo <[email protected]> Co-authored-by: sethrubenstein <[email protected]> Co-authored-by: colorful-tones <[email protected]>
Co-authored-by: ocean90 <[email protected]> Co-authored-by: t-hamano <[email protected]>
* DateTimePicker: Change day button size back from 32px to 28px * Update changelog Co-authored-by: t-hamano <[email protected]> Co-authored-by: mirka <[email protected]> Co-authored-by: annezazu <[email protected]> Co-authored-by: getdave <[email protected]>
Co-authored-by: matiasbenedetto <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: mikachan <[email protected]> Co-authored-by: creativecoder <[email protected]> Co-authored-by: desrosj <[email protected]> Co-authored-by: estelaris <[email protected]> Co-authored-by: YanCol <[email protected]>
tellthemachines
requested review from
ajitbohra,
ellatrix,
artemiomorales and
michalczaplinski
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This was referenced Apr 9, 2024
tellthemachines
added
the
[Type] Bug
|
Size Change: +148 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
Oh, I hear ya! 😅 Good thinking skipping that one for the Gutenberg cherry picking 👍 |
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Apr 9, 2024
Updates the editor npm packages to the latest patch versions for 6.5.1. See WordPress/gutenberg#60577. git-svn-id: https://develop.svn.wordpress.org/trunk@57949 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Apr 9, 2024
Updates the editor npm packages to the latest patch versions for 6.5.1. See WordPress/gutenberg#60577. Built from https://develop.svn.wordpress.org/trunk@57949 git-svn-id: http://core.svn.wordpress.org/trunk@57446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Apr 9, 2024
Updates the editor npm packages to the latest patch versions for 6.5.1. See WordPress/gutenberg#60577. Built from https://develop.svn.wordpress.org/trunk@57949 git-svn-id: https://core.svn.wordpress.org/trunk@57446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PRs are included:
#59981 – Font Library: Reset notices when navigating away from the collection
#59990 – DateTimePicker: Change day button size back from 32px to 28px
#60014 – Pattern Explorer: Pass 'rootClientId' to the pattern list
#59890 – Fix lightbox UI disallow editing
#60426 – Only show inserter in document tools if DFM is off
#60406 – Fix don't close overlay menu when focus leaves submenu
#60451 – Fix experimental useHasRecursion deprecation
#60452 – Fix pattern block recursion handling
#60431 – Remove alpha from edit post header
#60438 – Avoid overriding custom settings on font library save
#60006 – Update the query block to permit non-core interactive blocks
#60520 – I18N: Add context to 'Library' string
I didn't include #60489 because the merge conflicts in the theme.json class test are almost impossible to untangle, and in any case it's a PHP only change so it needs to go into core directly.