Site Editor: Add rename page command #60231
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Enhancement
|
Size Change: +305 B (0%) Total Size: 1.73 MB
ℹ️ View Unchanged
|
|
There are still a couple of edge cases here that I'm in the process of addressing, e.g. the command isn't working with table dataview. I'll be AFK until the middle of next week but will pick this up again as soon as I'm back. |
ntsekouras
force-pushed
the
add/page-rename-action
branch
from
e9e2028
to
d7823cb
Compare
The non-list dataviews (grid and table) don't render the |
|
Looks like there's been some refactoring merged in trunk moving the actions to the editor package. I'll keep this in draft status until I get a chance to update this PR accordingly to resolve conflicts. |
Remove isEligible
The page command modals are normally added to the Editor component however with the new dataviews layouts including grid and table, the Editor isn't rendered so without this misses out on the modal.
aaronrobertshaw
force-pushed
the
add/rename-page-command
branch
from
f03fe87
to
735d970
Compare
|
This should be ready for some feedback now 🙏 In particular, it would be great to get some thoughts on better approaches to ensuring the command modal can be displayed regardless of whether we have the Editor preview or only DataViews with a non-list list layout e.g. grid or table view. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
There was some feedback on the addition of rename and trash options to the page panel that features should be added to either both editors or none. As a result, this PR might need some further tweaks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
Adds a command to the site editor for easier renaming of pages
Why?
If a page doesn't include a Title block there is no easy way to update the page while editing it within the site editor.
How?
PageModalcomponent is currently added to both thePagePagescomponent and the site editor'sEditorto cover when the command is used while editing a page or on its details nav screen as well as when the entire page is a dataview only e.g. with the grid or table layouts.Open to suggestions on a better approach to that last point!
Known Issue
With DataView layouts that appear alongside an editor, notices are shown in two snackbar lists. There is an open issue for this (#60457) so it will be addressed separately.
Testing Instructions
Screenshots or screencast
Screen.Recording.2024-03-27.at.2.39.36.PM.mp4