-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template Parts: Add rename template part command #55339
base: trunk
Are you sure you want to change the base?
Conversation
Size Change: +394 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
Flaky tests detected in f03551c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8387165600
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smoke tests according to test steps and all is working well for me so far.
The basic knowledge I've amassed from looking at #54271 is that any effort to create smaller, logical components is worth it! Thanks!
Whether or not the template part commands and modals should be managed on their own or alongside patterns
Does the latter mean managed from the patterns package?
Also not sure if I'm comprehending this part of the test steps right:
- Select a non-customized theme provided template part
- Confirm that you do not get the rename template part command
- Customize the template part
- Confirm that you now get the rename command and it works as expected
Should a theme-provided template part have a rename command? In testing it doesn't, but it does allow for clearing customizations, which I'd expect.
Thanks!
packages/edit-site/src/hooks/commands/use-edit-mode-commands.js
Outdated
Show resolved
Hide resolved
packages/edit-site/src/hooks/commands/use-edit-mode-commands.js
Outdated
Show resolved
Hide resolved
Thanks for the early feedback, testing, and sanity check @ramonjd 🙇
Yeah, at what point should we bring this into the patterns package? Now or only when we're unifying template parts and patterns so the patterns package remains more purely about patterns.
Murky test instructions sorry. The key was to select/click on a template part, taking you to the view page for the template part. On this page, I do get the rename template part command and it does work for step 7. From there, clearing the customizations does mean the template part is back to the original name as the original theme-provided template part is restored. Screen.Recording.2023-10-17.at.5.13.52.pm.mp4So I guess the next question is should I disallow the renaming of template parts even if they have been customized (which creates a copy of the theme-provided part in the corresponding CPT) or allow the renaming of customized template parts from the main Patterns grid view page? What do you think? |
c673833
to
f03551c
Compare
Related:
What?
Adds a rename template part command.
Note: Whether or not the template part commands and modals should be managed on their own or alongside patterns is still a bit unclear at the moment and likely to change based on feedback.
Refactoring or consolidating the modal components will be looked into via a follow-up.
Why?
This is a step toward parity between the template part and pattern functionality in the site editor. It also lays the ground work for allowing quick duplication of a template part via a duplicate command.
How?
Testing Instructions
Screenshots or screencast
Screen.Recording.2024-03-22.at.5.44.58.PM.mp4
Original incarnation of this pre dataviews for patterns
What?
Adds a rename template part command and simplifies the pattern page's
RenameMenuItem
component.Note: Whether or not the template part commands and modals should be managed on their own or alongside patterns is still a bit unclear at the moment and likely to change based on feedback.
Why?
This is a step toward parity between the template part and pattern functionality in the site editor. It also lays the ground work for allowing quick duplication of a template part via a duplicate command.
How?
RenameTemplatePartModal
from the pattern page'sRenameMenuItem
RenameMenuItem
to use the new rename modals for patterns and template partsTesting Instructions
Screenshots or screencast
Screen.Recording.2023-10-13.at.6.28.12.pm.mp4