Restore site editor navigation panel edit button. #59429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +35 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
I don't think it is 'broken'. It just doesn't look nice. Also, the edito already supports editing some objects 'in isolation' for example patterns in 6.5 and that makes perfectly sense to me. I tend to think #59340 actually cures the symptom rather than solvign the root problem. Also, I'd like to stress again that consistency is key. Users are already greatly confused because ofthen the editor views work in a different way. SOmetimes users can edit, sometimes not, and it's not clear why. Introducing more inconsistency isn't the best way to provide a better user experience, IMHO. |
afercia
force-pushed
the
fix/restore-site-editor-navigation-panel-edit-button
branch
from
7738a37
to
57a728d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59372
What?
Reverts the changes from #59335
Restores the 'Edit' icon button in the site editor navigation panel.
Why?
How?
Reverts the changes from #59335
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before:
After: