Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't navigate to navigation post type #59340

Closed

Conversation

draganescu
Copy link
Contributor

@draganescu draganescu commented Feb 24, 2024

What?

In the site editor when using the sidebar to go to Navigation>[Single navigation] the frame would show the contents of the wp_navigation post type. This PR keeps the frame showing the homepage.

Why?

The original intent was to allow a sort of zoomed in editing for the navigation. This has not amounted to much and now it's a confusing screen which does more harm than good.

How?

Update the route for single navigation in the site editor to not include a post type so that the editor in the frame does not try to edit it. Updates the path of navigations in the list of navigations in the site editor sidebar Navigation section.

Testing Instructions

  1. Make sure to have some navigations
  2. Go to the site editor
  3. Go to Navigation
  4. Click on a navigation
  5. Notice the right side preview is still showing the homepage
  6. Notice the navigation editing in the sidebar still works

Testing Instructions for Keyboard

Screenshots or screencast

frame-shows-home.mp4

@draganescu draganescu marked this pull request as ready for review February 24, 2024 12:29
Copy link

github-actions bot commented Feb 24, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: draganescu <[email protected]>
Co-authored-by: getdave <[email protected]>
Co-authored-by: fabiankaegy <[email protected]>
Co-authored-by: afercia <[email protected]>
Co-authored-by: richtabor <[email protected]>
Co-authored-by: jameskoster <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@draganescu draganescu added [Type] Enhancement A suggestion for improvement. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Feb 24, 2024
Copy link

github-actions bot commented Feb 24, 2024

Size Change: +4 B (0%)

Total Size: 1.71 MB

Filename Size Change
build/edit-site/index.min.js 218 kB +4 B (0%)
ℹ️ View Unchanged
Filename Size
build/a11y/index.min.js 955 B
build/annotations/index.min.js 2.69 kB
build/api-fetch/index.min.js 2.32 kB
build/autop/index.min.js 2.1 kB
build/blob/index.min.js 578 B
build/block-directory/index.min.js 7.26 kB
build/block-directory/style-rtl.css 1.03 kB
build/block-directory/style.css 1.03 kB
build/block-editor/content-rtl.css 4.43 kB
build/block-editor/content.css 4.43 kB
build/block-editor/default-editor-styles-rtl.css 394 B
build/block-editor/default-editor-styles.css 394 B
build/block-editor/index.min.js 252 kB
build/block-editor/style-rtl.css 15.6 kB
build/block-editor/style.css 15.6 kB
build/block-library/blocks/archives/editor-rtl.css 61 B
build/block-library/blocks/archives/editor.css 60 B
build/block-library/blocks/archives/style-rtl.css 90 B
build/block-library/blocks/archives/style.css 90 B
build/block-library/blocks/audio/editor-rtl.css 150 B
build/block-library/blocks/audio/editor.css 150 B
build/block-library/blocks/audio/style-rtl.css 122 B
build/block-library/blocks/audio/style.css 122 B
build/block-library/blocks/audio/theme-rtl.css 126 B
build/block-library/blocks/audio/theme.css 126 B
build/block-library/blocks/avatar/editor-rtl.css 116 B
build/block-library/blocks/avatar/editor.css 116 B
build/block-library/blocks/avatar/style-rtl.css 104 B
build/block-library/blocks/avatar/style.css 104 B
build/block-library/blocks/block/editor-rtl.css 305 B
build/block-library/blocks/block/editor.css 305 B
build/block-library/blocks/button/editor-rtl.css 415 B
build/block-library/blocks/button/editor.css 414 B
build/block-library/blocks/button/style-rtl.css 627 B
build/block-library/blocks/button/style.css 626 B
build/block-library/blocks/buttons/editor-rtl.css 337 B
build/block-library/blocks/buttons/editor.css 337 B
build/block-library/blocks/buttons/style-rtl.css 332 B
build/block-library/blocks/buttons/style.css 332 B
build/block-library/blocks/calendar/style-rtl.css 239 B
build/block-library/blocks/calendar/style.css 239 B
build/block-library/blocks/categories/editor-rtl.css 113 B
build/block-library/blocks/categories/editor.css 112 B
build/block-library/blocks/categories/style-rtl.css 124 B
build/block-library/blocks/categories/style.css 124 B
build/block-library/blocks/code/editor-rtl.css 53 B
build/block-library/blocks/code/editor.css 53 B
build/block-library/blocks/code/style-rtl.css 121 B
build/block-library/blocks/code/style.css 121 B
build/block-library/blocks/code/theme-rtl.css 124 B
build/block-library/blocks/code/theme.css 124 B
build/block-library/blocks/columns/editor-rtl.css 108 B
build/block-library/blocks/columns/editor.css 108 B
build/block-library/blocks/columns/style-rtl.css 421 B
build/block-library/blocks/columns/style.css 421 B
build/block-library/blocks/comment-author-avatar/editor-rtl.css 125 B
build/block-library/blocks/comment-author-avatar/editor.css 125 B
build/block-library/blocks/comment-content/style-rtl.css 92 B
build/block-library/blocks/comment-content/style.css 92 B
build/block-library/blocks/comment-template/style-rtl.css 199 B
build/block-library/blocks/comment-template/style.css 198 B
build/block-library/blocks/comments-pagination-numbers/editor-rtl.css 123 B
build/block-library/blocks/comments-pagination-numbers/editor.css 121 B
build/block-library/blocks/comments-pagination/editor-rtl.css 222 B
build/block-library/blocks/comments-pagination/editor.css 209 B
build/block-library/blocks/comments-pagination/style-rtl.css 235 B
build/block-library/blocks/comments-pagination/style.css 231 B
build/block-library/blocks/comments-title/editor-rtl.css 75 B
build/block-library/blocks/comments-title/editor.css 75 B
build/block-library/blocks/comments/editor-rtl.css 840 B
build/block-library/blocks/comments/editor.css 839 B
build/block-library/blocks/comments/style-rtl.css 637 B
build/block-library/blocks/comments/style.css 636 B
build/block-library/blocks/cover/editor-rtl.css 647 B
build/block-library/blocks/cover/editor.css 650 B
build/block-library/blocks/cover/style-rtl.css 1.69 kB
build/block-library/blocks/cover/style.css 1.68 kB
build/block-library/blocks/details/editor-rtl.css 65 B
build/block-library/blocks/details/editor.css 65 B
build/block-library/blocks/details/style-rtl.css 98 B
build/block-library/blocks/details/style.css 98 B
build/block-library/blocks/embed/editor-rtl.css 322 B
build/block-library/blocks/embed/editor.css 322 B
build/block-library/blocks/embed/style-rtl.css 410 B
build/block-library/blocks/embed/style.css 410 B
build/block-library/blocks/embed/theme-rtl.css 126 B
build/block-library/blocks/embed/theme.css 126 B
build/block-library/blocks/file/editor-rtl.css 316 B
build/block-library/blocks/file/editor.css 316 B
build/block-library/blocks/file/style-rtl.css 280 B
build/block-library/blocks/file/style.css 281 B
build/block-library/blocks/file/view.min.js 324 B
build/block-library/blocks/footnotes/style-rtl.css 201 B
build/block-library/blocks/footnotes/style.css 199 B
build/block-library/blocks/form-input/editor-rtl.css 227 B
build/block-library/blocks/form-input/editor.css 227 B
build/block-library/blocks/form-input/style-rtl.css 343 B
build/block-library/blocks/form-input/style.css 343 B
build/block-library/blocks/form-submission-notification/editor-rtl.css 340 B
build/block-library/blocks/form-submission-notification/editor.css 340 B
build/block-library/blocks/form-submit-button/style-rtl.css 69 B
build/block-library/blocks/form-submit-button/style.css 69 B
build/block-library/blocks/form/view.min.js 471 B
build/block-library/blocks/freeform/editor-rtl.css 2.61 kB
build/block-library/blocks/freeform/editor.css 2.61 kB
build/block-library/blocks/gallery/editor-rtl.css 947 B
build/block-library/blocks/gallery/editor.css 952 B
build/block-library/blocks/gallery/style-rtl.css 1.72 kB
build/block-library/blocks/gallery/style.css 1.72 kB
build/block-library/blocks/gallery/theme-rtl.css 108 B
build/block-library/blocks/gallery/theme.css 108 B
build/block-library/blocks/group/editor-rtl.css 647 B
build/block-library/blocks/group/editor.css 647 B
build/block-library/blocks/group/style-rtl.css 57 B
build/block-library/blocks/group/style.css 57 B
build/block-library/blocks/group/theme-rtl.css 78 B
build/block-library/blocks/group/theme.css 78 B
build/block-library/blocks/heading/style-rtl.css 189 B
build/block-library/blocks/heading/style.css 189 B
build/block-library/blocks/html/editor-rtl.css 336 B
build/block-library/blocks/html/editor.css 337 B
build/block-library/blocks/image/editor-rtl.css 878 B
build/block-library/blocks/image/editor.css 878 B
build/block-library/blocks/image/style-rtl.css 1.6 kB
build/block-library/blocks/image/style.css 1.59 kB
build/block-library/blocks/image/theme-rtl.css 126 B
build/block-library/blocks/image/theme.css 126 B
build/block-library/blocks/image/view.min.js 1.54 kB
build/block-library/blocks/latest-comments/style-rtl.css 357 B
build/block-library/blocks/latest-comments/style.css 357 B
build/block-library/blocks/latest-posts/editor-rtl.css 213 B
build/block-library/blocks/latest-posts/editor.css 212 B
build/block-library/blocks/latest-posts/style-rtl.css 478 B
build/block-library/blocks/latest-posts/style.css 478 B
build/block-library/blocks/list/style-rtl.css 88 B
build/block-library/blocks/list/style.css 88 B
build/block-library/blocks/media-text/editor-rtl.css 306 B
build/block-library/blocks/media-text/editor.css 305 B
build/block-library/blocks/media-text/style-rtl.css 505 B
build/block-library/blocks/media-text/style.css 503 B
build/block-library/blocks/more/editor-rtl.css 431 B
build/block-library/blocks/more/editor.css 431 B
build/block-library/blocks/navigation-link/editor-rtl.css 668 B
build/block-library/blocks/navigation-link/editor.css 669 B
build/block-library/blocks/navigation-link/style-rtl.css 259 B
build/block-library/blocks/navigation-link/style.css 257 B
build/block-library/blocks/navigation-submenu/editor-rtl.css 296 B
build/block-library/blocks/navigation-submenu/editor.css 295 B
build/block-library/blocks/navigation/editor-rtl.css 2.26 kB
build/block-library/blocks/navigation/editor.css 2.26 kB
build/block-library/blocks/navigation/style-rtl.css 2.26 kB
build/block-library/blocks/navigation/style.css 2.25 kB
build/block-library/blocks/navigation/view.min.js 1.02 kB
build/block-library/blocks/nextpage/editor-rtl.css 395 B
build/block-library/blocks/nextpage/editor.css 395 B
build/block-library/blocks/page-list/editor-rtl.css 377 B
build/block-library/blocks/page-list/editor.css 377 B
build/block-library/blocks/page-list/style-rtl.css 175 B
build/block-library/blocks/page-list/style.css 175 B
build/block-library/blocks/paragraph/editor-rtl.css 235 B
build/block-library/blocks/paragraph/editor.css 235 B
build/block-library/blocks/paragraph/style-rtl.css 335 B
build/block-library/blocks/paragraph/style.css 335 B
build/block-library/blocks/post-author/style-rtl.css 175 B
build/block-library/blocks/post-author/style.css 176 B
build/block-library/blocks/post-comments-form/editor-rtl.css 96 B
build/block-library/blocks/post-comments-form/editor.css 96 B
build/block-library/blocks/post-comments-form/style-rtl.css 508 B
build/block-library/blocks/post-comments-form/style.css 508 B
build/block-library/blocks/post-content/editor-rtl.css 74 B
build/block-library/blocks/post-content/editor.css 74 B
build/block-library/blocks/post-date/style-rtl.css 61 B
build/block-library/blocks/post-date/style.css 61 B
build/block-library/blocks/post-excerpt/editor-rtl.css 71 B
build/block-library/blocks/post-excerpt/editor.css 71 B
build/block-library/blocks/post-excerpt/style-rtl.css 141 B
build/block-library/blocks/post-excerpt/style.css 141 B
build/block-library/blocks/post-featured-image/editor-rtl.css 666 B
build/block-library/blocks/post-featured-image/editor.css 662 B
build/block-library/blocks/post-featured-image/style-rtl.css 342 B
build/block-library/blocks/post-featured-image/style.css 342 B
build/block-library/blocks/post-navigation-link/style-rtl.css 215 B
build/block-library/blocks/post-navigation-link/style.css 214 B
build/block-library/blocks/post-template/editor-rtl.css 99 B
build/block-library/blocks/post-template/editor.css 98 B
build/block-library/blocks/post-template/style-rtl.css 409 B
build/block-library/blocks/post-template/style.css 408 B
build/block-library/blocks/post-terms/style-rtl.css 96 B
build/block-library/blocks/post-terms/style.css 96 B
build/block-library/blocks/post-time-to-read/style-rtl.css 69 B
build/block-library/blocks/post-time-to-read/style.css 69 B
build/block-library/blocks/post-title/style-rtl.css 100 B
build/block-library/blocks/post-title/style.css 100 B
build/block-library/blocks/preformatted/style-rtl.css 125 B
build/block-library/blocks/preformatted/style.css 125 B
build/block-library/blocks/pullquote/editor-rtl.css 135 B
build/block-library/blocks/pullquote/editor.css 135 B
build/block-library/blocks/pullquote/style-rtl.css 354 B
build/block-library/blocks/pullquote/style.css 354 B
build/block-library/blocks/pullquote/theme-rtl.css 168 B
build/block-library/blocks/pullquote/theme.css 168 B
build/block-library/blocks/query-pagination-numbers/editor-rtl.css 122 B
build/block-library/blocks/query-pagination-numbers/editor.css 121 B
build/block-library/blocks/query-pagination/editor-rtl.css 221 B
build/block-library/blocks/query-pagination/editor.css 211 B
build/block-library/blocks/query-pagination/style-rtl.css 288 B
build/block-library/blocks/query-pagination/style.css 284 B
build/block-library/blocks/query-title/style-rtl.css 63 B
build/block-library/blocks/query-title/style.css 63 B
build/block-library/blocks/query/editor-rtl.css 486 B
build/block-library/blocks/query/editor.css 486 B
build/block-library/blocks/query/view.min.js 958 B
build/block-library/blocks/quote/style-rtl.css 237 B
build/block-library/blocks/quote/style.css 237 B
build/block-library/blocks/quote/theme-rtl.css 223 B
build/block-library/blocks/quote/theme.css 226 B
build/block-library/blocks/read-more/style-rtl.css 140 B
build/block-library/blocks/read-more/style.css 140 B
build/block-library/blocks/rss/editor-rtl.css 149 B
build/block-library/blocks/rss/editor.css 149 B
build/block-library/blocks/rss/style-rtl.css 289 B
build/block-library/blocks/rss/style.css 288 B
build/block-library/blocks/search/editor-rtl.css 184 B
build/block-library/blocks/search/editor.css 184 B
build/block-library/blocks/search/style-rtl.css 629 B
build/block-library/blocks/search/style.css 628 B
build/block-library/blocks/search/theme-rtl.css 114 B
build/block-library/blocks/search/theme.css 114 B
build/block-library/blocks/search/view.min.js 478 B
build/block-library/blocks/separator/editor-rtl.css 146 B
build/block-library/blocks/separator/editor.css 146 B
build/block-library/blocks/separator/style-rtl.css 229 B
build/block-library/blocks/separator/style.css 229 B
build/block-library/blocks/separator/theme-rtl.css 194 B
build/block-library/blocks/separator/theme.css 194 B
build/block-library/blocks/shortcode/editor-rtl.css 323 B
build/block-library/blocks/shortcode/editor.css 323 B
build/block-library/blocks/site-logo/editor-rtl.css 754 B
build/block-library/blocks/site-logo/editor.css 754 B
build/block-library/blocks/site-logo/style-rtl.css 204 B
build/block-library/blocks/site-logo/style.css 204 B
build/block-library/blocks/site-tagline/editor-rtl.css 86 B
build/block-library/blocks/site-tagline/editor.css 86 B
build/block-library/blocks/site-title/editor-rtl.css 116 B
build/block-library/blocks/site-title/editor.css 116 B
build/block-library/blocks/site-title/style-rtl.css 57 B
build/block-library/blocks/site-title/style.css 57 B
build/block-library/blocks/social-link/editor-rtl.css 184 B
build/block-library/blocks/social-link/editor.css 184 B
build/block-library/blocks/social-links/editor-rtl.css 682 B
build/block-library/blocks/social-links/editor.css 681 B
build/block-library/blocks/social-links/style-rtl.css 1.48 kB
build/block-library/blocks/social-links/style.css 1.48 kB
build/block-library/blocks/spacer/editor-rtl.css 350 B
build/block-library/blocks/spacer/editor.css 350 B
build/block-library/blocks/spacer/style-rtl.css 48 B
build/block-library/blocks/spacer/style.css 48 B
build/block-library/blocks/table/editor-rtl.css 395 B
build/block-library/blocks/table/editor.css 395 B
build/block-library/blocks/table/style-rtl.css 639 B
build/block-library/blocks/table/style.css 639 B
build/block-library/blocks/table/theme-rtl.css 146 B
build/block-library/blocks/table/theme.css 146 B
build/block-library/blocks/tag-cloud/style-rtl.css 251 B
build/block-library/blocks/tag-cloud/style.css 253 B
build/block-library/blocks/template-part/editor-rtl.css 403 B
build/block-library/blocks/template-part/editor.css 403 B
build/block-library/blocks/template-part/theme-rtl.css 101 B
build/block-library/blocks/template-part/theme.css 101 B
build/block-library/blocks/term-description/style-rtl.css 111 B
build/block-library/blocks/term-description/style.css 111 B
build/block-library/blocks/text-columns/editor-rtl.css 95 B
build/block-library/blocks/text-columns/editor.css 95 B
build/block-library/blocks/text-columns/style-rtl.css 166 B
build/block-library/blocks/text-columns/style.css 166 B
build/block-library/blocks/verse/style-rtl.css 99 B
build/block-library/blocks/verse/style.css 99 B
build/block-library/blocks/video/editor-rtl.css 552 B
build/block-library/blocks/video/editor.css 555 B
build/block-library/blocks/video/style-rtl.css 185 B
build/block-library/blocks/video/style.css 185 B
build/block-library/blocks/video/theme-rtl.css 126 B
build/block-library/blocks/video/theme.css 126 B
build/block-library/classic-rtl.css 179 B
build/block-library/classic.css 179 B
build/block-library/common-rtl.css 1.11 kB
build/block-library/common.css 1.11 kB
build/block-library/editor-elements-rtl.css 75 B
build/block-library/editor-elements.css 75 B
build/block-library/editor-rtl.css 12.4 kB
build/block-library/editor.css 12.4 kB
build/block-library/elements-rtl.css 54 B
build/block-library/elements.css 54 B
build/block-library/index.min.js 218 kB
build/block-library/reset-rtl.css 472 B
build/block-library/reset.css 472 B
build/block-library/style-rtl.css 14.8 kB
build/block-library/style.css 14.8 kB
build/block-library/theme-rtl.css 688 B
build/block-library/theme.css 693 B
build/block-serialization-default-parser/index.min.js 1.12 kB
build/block-serialization-spec-parser/index.min.js 2.87 kB
build/blocks/index.min.js 51.8 kB
build/commands/index.min.js 15.6 kB
build/commands/style-rtl.css 935 B
build/commands/style.css 930 B
build/components/index.min.js 224 kB
build/components/style-rtl.css 11.8 kB
build/components/style.css 11.9 kB
build/compose/index.min.js 12.6 kB
build/core-commands/index.min.js 2.77 kB
build/core-data/index.min.js 72.8 kB
build/customize-widgets/index.min.js 11.2 kB
build/customize-widgets/style-rtl.css 1.36 kB
build/customize-widgets/style.css 1.36 kB
build/data-controls/index.min.js 640 B
build/data/index.min.js 8.95 kB
build/date/index.min.js 17.9 kB
build/deprecated/index.min.js 451 B
build/dom-ready/index.min.js 324 B
build/dom/index.min.js 4.65 kB
build/edit-post/classic-rtl.css 558 B
build/edit-post/classic.css 558 B
build/edit-post/index.min.js 24.2 kB
build/edit-post/style-rtl.css 5.58 kB
build/edit-post/style.css 5.57 kB
build/edit-site/style-rtl.css 15 kB
build/edit-site/style.css 15 kB
build/edit-widgets/index.min.js 17.3 kB
build/edit-widgets/style-rtl.css 4.17 kB
build/edit-widgets/style.css 4.16 kB
build/editor/index.min.js 64 kB
build/editor/style-rtl.css 5.36 kB
build/editor/style.css 5.35 kB
build/element/index.min.js 4.83 kB
build/escape-html/index.min.js 537 B
build/format-library/index.min.js 8.03 kB
build/format-library/style-rtl.css 492 B
build/format-library/style.css 490 B
build/hooks/index.min.js 1.55 kB
build/html-entities/index.min.js 448 B
build/i18n/index.min.js 3.58 kB
build/interactivity/file.min.js 447 B
build/interactivity/image.min.js 1.67 kB
build/interactivity/index.min.js 13 kB
build/interactivity/navigation.min.js 1.15 kB
build/interactivity/query.min.js 740 B
build/interactivity/router.min.js 1.36 kB
build/interactivity/search.min.js 618 B
build/is-shallow-equal/index.min.js 527 B
build/keyboard-shortcuts/index.min.js 1.74 kB
build/keycodes/index.min.js 1.46 kB
build/list-reusable-blocks/index.min.js 2.11 kB
build/list-reusable-blocks/style-rtl.css 851 B
build/list-reusable-blocks/style.css 849 B
build/media-utils/index.min.js 2.92 kB
build/modules/importmap-polyfill.min.js 12.2 kB
build/notices/index.min.js 948 B
build/nux/index.min.js 2 kB
build/nux/style-rtl.css 747 B
build/nux/style.css 742 B
build/patterns/index.min.js 5.73 kB
build/patterns/style-rtl.css 553 B
build/patterns/style.css 552 B
build/plugins/index.min.js 1.8 kB
build/preferences-persistence/index.min.js 2.05 kB
build/preferences/index.min.js 2.81 kB
build/preferences/style-rtl.css 710 B
build/preferences/style.css 712 B
build/primitives/index.min.js 975 B
build/priority-queue/index.min.js 1.52 kB
build/private-apis/index.min.js 1 kB
build/react-i18n/index.min.js 623 B
build/react-refresh-entry/index.min.js 9.47 kB
build/react-refresh-runtime/index.min.js 6.78 kB
build/redux-routine/index.min.js 2.7 kB
build/reusable-blocks/index.min.js 2.73 kB
build/reusable-blocks/style-rtl.css 256 B
build/reusable-blocks/style.css 256 B
build/rich-text/index.min.js 10.5 kB
build/router/index.min.js 1.79 kB
build/server-side-render/index.min.js 1.96 kB
build/shortcode/index.min.js 1.39 kB
build/style-engine/index.min.js 2.1 kB
build/token-list/index.min.js 582 B
build/url/index.min.js 3.72 kB
build/vendors/inert-polyfill.min.js 2.48 kB
build/vendors/react-dom.min.js 41.7 kB
build/vendors/react.min.js 4.02 kB
build/viewport/index.min.js 957 B
build/warning/index.min.js 249 B
build/widgets/index.min.js 7.21 kB
build/widgets/style-rtl.css 1.17 kB
build/widgets/style.css 1.17 kB
build/wordcount/index.min.js 1.02 kB

compressed-size-action

@fabiankaegy
Copy link
Member

@draganescu I in theory like this because the sidebar editing is much simpler than the experience when the single navigation is loaded in the editor. However this currently doesn't support a bunch of interactions like adding new menu items, converting something to a submenu etc.

Because of that I don't think we can get rid of the current experience just yet. Not until there is feature parity in the sidebar experience.

@draganescu
Copy link
Contributor Author

@fabiankaegy i do think the sidebar navigation menu handling should be improved but I am convinced the current situation does more harm than good.

The editor is working with the menu data directly, users can't style and it's extremely unclear what is actually being done. Plus the UI is so unpolished that the whole editor seems broken.

I don't think we should wait for parity - on the contrary removing this stop gap will accelerate the need for figuring out the navigation menu handling in the site editor sidebar.

@draganescu draganescu force-pushed the remove/navigation-standalone-editor-site-editor branch from 4f5bb92 to 00a3f72 Compare March 18, 2024 13:39
@afercia
Copy link
Contributor

afercia commented Mar 20, 2024

I agree with @fabiankaegy. As I mentioned in #59372

I'm not sure the navigation panel should be a place where items can be edited 'in place' in the panel itself in the first place. Additionally, there are other actions that can only be performed in edit mode. For example, renaming a link, adding new links and possibly other actions.

I think that, while the intent of this PR is good, it actually cures the symptom rather than the disease. To me:

  • The navigation panel should never, ever, evolve to an editing UI. That's not the plate to edit. While some minor actions like move up/down, delete, rename, can be added to the navigation panel, a full editing experience can only be provided within the editor canvas.
  • The editor already allows to edit some objects 'in isolation', for example patterns. It makes perfectly sense to reenforce this concpet and allow other objects to be edited in isolation. Consistency is key. As a useer, when I click a pattern I expect to get the edit view. When I click a menu, I expect to get the edit view.
  • I tested this PR and, to me, the experiences just feels not right. When I navigate to a menu, I still see a page in the editor canvas. It feels like the editor is broken, in a way. A dead end where I can only move/remove menu items. At this point, what's the entire purpose of navigating to a menu?

Overall, I think the editor should go in the opposite direction. Keep navigation to the menu edit 'isolated' view. Make it nices and easier to use.

@draganescu draganescu self-assigned this Mar 20, 2024
@richtabor
Copy link
Member

I lean towards removing this route as well.

I've not been a fan of the single-navigation view as it was introduced. It's not any more helpful than the navigation as it appears on the site, but more confusing because it does not look like the navigation on your site—even though it's visually presented as such.

I think if we eventually do something like the WP Admin menu view (more of an actual UI around an isolated menu editing experience), then it'd be a more viable solution. But even then, I'm not certain it's the right direction.

+1

@richtabor
Copy link
Member

The editor already allows to edit some objects 'in isolation', for example patterns. It makes perfectly sense to reenforce this concpet and allow other objects to be edited in isolation. Consistency is key. As a useer, when I click a pattern I expect to get the edit view. When I click a menu, I expect to get the edit view.

Those isolated elements of a site are 1:1 to the element; not a representation of some sort.

At this point, what's the entire purpose of navigating to a menu?

I question its purpose as well, but the current experience does not warrant enough of a purpose. It could be more like the style book, where when you select a navigation, it opens up in the editor with the Inspector ready to go, but even then that's tricky, as the menu may not be on the current page.

@fabiankaegy
Copy link
Member

I am currently working on an interesting use case that I haven't found a way to accomplish without the navigation editor screen here.

This site has multiple different header menus that get curated manually by editors.

On the frontend the site header navigation then pulls in the appropriate navigation for the current user based on a few conditions.

Essentially this is a personalization feature for the navigation.

But because the different menus are not actually used on any template / template part, there is no way to edit them without this single view.

In this case we even exposed the wp-admin/edit.php?post_type=wp_navigation page as a menu item under the Appearance menu to allow easier creation / direct links to the various navigations.


I'm saying all this not because I like the single navigation editor as it works today. In fact I really dislike it and find it very hard to use.

Instead I'm saying that currently you are forced to use it because there are no real alternatives.

What I would love to see here is something similar to what WooCommerce did with their Product editor experience. An abstracted representation of the menu where you can easily manage the structure without really having to think of the menu items as blocks.

@draganescu
Copy link
Contributor Author

Thank you for the use case @fabiankaegy I think that does raise a need to not remove this for now, maybe move it?

@getdave
Copy link
Contributor

getdave commented Apr 22, 2024

I'm not arguing that what we have today is a great experience - far from it. However, I am sounding a note of caution that we should consider not removing things without ensuring the use cases it served are covered elsewhere in the experience.

In this case @fabiankaegy makes the critical point about the ability to manage Navigations which are not currently in use in any template.

Whilst this is no doubt an advanced use case it is one that is valid and thus I think completely dropping the ability to access the editor would be a mistake.

Stretch goal effort

One way I could see this happening is if we lean into the new Data views "List" layout for Navigation. We're already doing this for Pages and other data types and I think Navigation could fit well here.

This would make the initial click through to the Navigation section more about managing your menus (rename/delete...etc).

The next step could be to introduce the editable list view (which we have in the Nav block's sidebar) into the "Content area" frame as a further click through. The functionality is all there and users have repeatedly requested the ability to manage menu items from this frame.

Navigation block editable list view Screen Shot 2024-04-22 at 09 33 47
Overview of Data Views "frames" Screenshot 2024-04-22 at 09 33 29

Once this is in place we could remove the "Navigation Editor" as it is today.

Alternative simpler effort

Another option might be to simply remove the ability to access the "Navigation Editor" view from the Navigation section. We could still retain the ability to access this view in some other way, but this way we would deprioritise it the UI thus avoiding confusion.

@jameskoster
Copy link
Contributor

I continue to wonder whether the management of multiple synced Navigation menus is over-emphasised in the site editor. Typically sites have one or two menus, and most of the time they live inside template parts which are already synced anyway.

For users, what should simply be a matter of editing the site header (including the menu) is over-complicated by additional touchpoints and interactions that add a lot of weight to the user experience.

maybe move it?

One way I could see this happening is if we lean into the new Data Views "List" layout for navigation

We have a place to manage synced entities – the Patterns page. The overlap between synced patterns and template parts has resulted in new efforts to align these concepts.

As a provocation, what if we did the same with synced navigation menus? Could there be a world where Navigation block contents are unsynced by default, and when you need to sync you just create a (synced) pattern? Advanced use cases as discussed are still catered to, but using familiar concepts and only as required rather than as the default. I think there could be potential for this to allow for more advanced expression, and at the same time simplify the experience for those majority use cases.

@getdave
Copy link
Contributor

getdave commented Apr 22, 2024

Thanks for thinking about this in the larger scope of WordPress.

It's really important we try and align concepts. I am however concerned that we don't add more confusion by obfuscating concepts such as "Navigation" and "Menu" which are universally understood.

For users, what should simply be a matter of editing the site header (including the menu) is over-complicated by additional touchpoints and interactions that add a lot of weight to the user experience.

Watching recent videos and listening to user feedback I would agree that what we have now is too complex.

That said, I'm curious to understand more about what you see as the "additional touchpoints". I assume one of those is the the Navigation focused editor that this PR seeks to remove?

If you want to edit your header Navigation you either:

  • click on the Navigation block in the header within the editor canvas and edit
  • click on the Navigation section in the sidebar, select the menu in question (assuming multiple menus present) and edit in the Navigation focused editor.

(Aside: if there is a single menu then we don't go to the isolated editor. It only happens if there are multiple menus - a more advanced use case)

Perhaps you mean that there are multiple ways to perform edits to your menu? These are:

  • in canvas - required as per the block paradigm.
  • editable list view (within inspector controls) - specific required to improve the UX around editing complex nested menus and, given the inherent complexity of the in-canvas block editing experience, is also a much better experience for users of assistive tech.
  • focused navigation editor - we all agree that in its current form this leaves much to be desired.

We have a place to manage synced entities – the Patterns page. The overlap between synced patterns and template parts has resulted in new efforts to align these concepts.

From analysing multiple UX sessions and videos, I believe users expect to see a top level menu item in the left hand sidebar labelled Navigation. It's universally understood in the web paradigm and one of the key elements of any serious website.

As a result there is an argument that we should be careful to retain this and avoid any temptation to obfuscate menu management behind other less concrete concepts such as patterns or templates.

As a provocation, what if we did the same with synced navigation menus? Could there be a world where Navigation block contents are unsynced by default, and when you need to sync you just create a (synced) pattern?

I appreciate the provocation here to think outside the box 👍 . However, it seems to me that by making Navigation unsynced by default we could be exposing users to unwanted complexity. The need to understand synced vs unsynced is just about fine for more complex items such as Patterns but not for something as basic as a menu which should "just work".


Having now worked within this area for several release cycles I am more and more convinced that in order to improve Navigation Menu management in WordPress we need to visualise some of the many possible UX directions we could take. These visualisation should obviously be taken "in the round" of the wider concepts under development such as data views and synced pattern overrides.

From here we could start to bring together a vision of where Navigation needs to be to be truly usable and intuitive in WordPress which would involve interactive prototypes backed up by an analysis of technical feasibility much the same as was done for the Link Editing UI.

I (and I'm sure other contributors) would be happy to work alongside a designer to do this.


For the purposes of this PR I think we should:

  • retain some means to access the focused Navigation editor
  • make it harder to accidentally end up in this screen from the default Editor experience when navigating to Navigation -> My Menu

The idea should be that this is an advanced view which can only be entered if you know about it.

@jameskoster
Copy link
Contributor

That said, I'm curious to understand more about what you see as the "additional touchpoints"

I'm basically referring to all the complexity that gets added by having to entertain menus as a post type all the time. Naming, deleting, switching, creating... all the different edit interfaces (like you mentioned), the little notices that appear when you edit a default menu (Pages List block), and so on. I appreciate we've attempted to give adequate prominence to these things but it still feels a bit overwhelming when compared to managing patterns which feels fairly streamlined by comparison. The biggest differentiator there is that syncing (a fairly advanced concept) is a user choice rather than a platform choice.

I know this is a very surface-level take, and agree it would be good to visualise a path forward.

@richtabor
Copy link
Member

One way I could see this happening is if we #59659 (comment). We're already doing this for Pages and other data types and I think Navigation could fit well here.

I'm not so concerned about getting to the menu, but rather the experience of editing it in isolation. It seems we're trying to emulate the functionality of this view, without building the corresponding editing experience as seen on the right:

CleanShot 2024-04-23 at 15 12 14

@getdave
Copy link
Contributor

getdave commented Apr 24, 2024

I'm not so concerned about getting to the menu,

...I think it's causing confusion to most users and only a small subset are likely making use of it. The rationale is therefore to deprioritise the ability to reach what is currently a confusing screen for most users.

...but rather the experience of editing it in isolation. It seems we're trying to emulate the functionality of this view, without building the corresponding editing experience as seen on the right:

As you may/may not be aware Gutenberg contributors previously explored creating such an interface as part of the "Navigation Editor" project. It was ultimately mothballed and then removed from the codebase as something we didn't want to pursue. Instead we chose to double down on improving the block and introduce alternative menu editing interfaces such as the editable List View.

Are you advocating pivoting the current navigation focus mode into an experience more akin to the Classic Menus screen?

@richtabor
Copy link
Member

Are you advocating pivoting the current navigation focus mode into an experience more akin to the Classic Menus screen?

Not necessarily, but we're sitting in the middle now with this view—where it does neither well enough. I do recall you experimented with a modal editor for navigation items as well, it could be similar to that perhaps? I don't think we should invest heavily in this though.

@getdave
Copy link
Contributor

getdave commented Apr 26, 2024

I don't think we should invest heavily in this though.

Agreed. I'd prefer to see the ability to edit Navigations from the sidebar area anyway.

I do recall you experimented with a modal editor for navigation items as well,

Yes it was an experimental Plugin which I need to revivie.

@draganescu
Copy link
Contributor Author

I agree with @getdave that:

For the purposes of this PR I think we should:

  • retain some means to access the focused Navigation editor
  • make it harder to accidentally end up in this screen from the default Editor experience when navigating to Navigation -> My Menu
    The idea should be that this is an advanced view which can only be entered if you know about it.

Who can help me:

  • move the access to this focused editor somewhere else :)

@richtabor
Copy link
Member

What about "Edit" here?

CleanShot 2024-04-29 at 15 47 28

@draganescu
Copy link
Contributor Author

Closed in favor of #61275

@draganescu draganescu closed this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Enhancement A suggestion for improvement.
Projects
Development

Successfully merging this pull request may close these issues.

6 participants