Writing flow: maintain correct selection after drag-selecting outside block #58684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @toncijajic. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core SVNIf you're a Core Committer, use this list when committing to GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +22 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
ellatrix
changed the title
|
Flaky tests detected in 3ebac69. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7788655417
|
jeryj
approved these changes
Feb 5, 2024
ellatrix
added
the
Backport to Gutenberg Minor Release
ellatrix
added a commit
that referenced
this pull request
Feb 5, 2024
|
Cherry picked this PR |
ellatrix
removed
the
Backport to Gutenberg Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The problem here is that the browser sort of destroys the selection after refocussing the editable element.
When dragging outside a block, we prepare the editor for (partial & full) multi-selection by making the whole editor
contenteditable. When you end the drag selection, but there is no multi selection, we need refocus the element where the selection started. The browser seems to not preserve the selection correctly on focus, so we have to clone the selection before focus, then restore it.I've added a test that currently fails with trunk.
Why?
Fixes #57894.
How?
Testing Instructions
With a single paragraph and some text, start a selection by dragging to the right but not to the end, then down to select the whole paragraph. Stop dragging. The selection to the end of the paragraph should be preserved.
Testing Instructions for Keyboard
Screenshots or screencast